Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support {input}.sigstore.json #814

Closed
woodruffw opened this issue Nov 16, 2023 · 2 comments · Fixed by #1007
Closed

Support {input}.sigstore.json #814

woodruffw opened this issue Nov 16, 2023 · 2 comments · Fixed by #1007
Assignees
@woodruffw
Labels
component:cli CLI components enhancement New feature or request
Milestone
3.0

Comments

@woodruffw
Copy link
Member

Per the Sigstore Client Spec

Two parts:

  1. sigstore sign should probably produce {input}.sigstore.json by default, rather than {input}.sigstore
  2. sigstore verify should accept either {input}.sigstore.json or {input}.sigstore, whichever is present (and probably fail if both are present)

(2) is pretty straightforward, and can be done in a backwards-compatible manner. (1) is a breaking change, so we'll either need to feature flag it or defer it until 3.0.
@woodruffw woodruffw added enhancement New feature or request component:cli CLI components labels Nov 16, 2023
@woodruffw woodruffw mentioned this issue Dec 4, 2023
Merged
@woodruffw
Copy link
Member Author

Opened #820 for (2) above.

@woodruffw woodruffw self-assigned this Dec 4, 2023
@woodruffw woodruffw mentioned this issue Dec 11, 2023
Merged
@woodruffw woodruffw added this to the 3.0 milestone Dec 19, 2023
@woodruffw
Copy link
Member Author

Marking with 3.0, since the default sigstore sign change will be incompatible.

woodruffw added a commit that referenced this issue May 9, 2024
@woodruffw
_cli: emit .sigstore.json by default
8c71205 
Closes #814.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw mentioned this issue May 9, 2024
Merged
@jku jku closed this as completed in #1007 May 13, 2024
jku pushed a commit that referenced this issue May 13, 2024
@woodruffw
_cli: emit .sigstore.json by default (#1007)
a86b7cb 
* _cli: emit .sigstore.json by default

Closes #814.

Signed-off-by: William Woodruff <william@trailofbits.com>

* CHANGELOG: record changes

Signed-off-by: William Woodruff <william@trailofbits.com>

* README: update `--help`

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
component:cli CLI components enhancement New feature or request
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

_cli: emit .sigstore.json by default sigstore/sigstore-python
1 participant
@woodruffw