Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ideas #940

Open
2 of 3 tasks
woodruffw opened this issue Mar 15, 2024 · 3 comments
Open
2 of 3 tasks

Refactoring ideas #940

woodruffw opened this issue Mar 15, 2024 · 3 comments
Labels
chore refactoring Refactoring tasks.

Comments

@woodruffw
Copy link
Member

woodruffw commented Mar 15, 2024

To avoid blowing up #937 even more, I'm listing these here for independent PRs:

  • sigstore.verify.models.Bundle should really be sigstore.Bundle or sigstore.models.Bundle or similar, since it's used across sign/verify.
  • sigstore.verify.models.VerificationResult and subclasses should all just live in sigstore.verify. The entire models.py file should probably go away.
  • sigstore._internal.merkle should probably be folded into sigstore.transparency, since it's entirely an implementation detail for LogEntry verification. Same for sigstore._internal.rekor.checkpoint.
@woodruffw woodruffw added refactoring Refactoring tasks. chore labels Mar 15, 2024
@woodruffw
Copy link
Member Author

#959 will remove VerificationResult entirely, in favor of an exception-driven verify API.

@woodruffw
Copy link
Member Author

Per #959 (comment): log_and_exit is maybe too clever, we should just spit out tracebacks directly for debugging in _cli.py.

@woodruffw
Copy link
Member Author

#989 has revealed a circular import that would be fixed by simplifying paths like sigstore.verify.models, so I'm going to go ahead and do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore refactoring Refactoring tasks.
Projects
None yet
Development

No branches or pull requests

1 participant