Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set user-agent in all HTTP requests #985

Closed
4 tasks done
jku opened this issue Apr 25, 2024 · 2 comments
Closed
4 tasks done

Set user-agent in all HTTP requests #985

jku opened this issue Apr 25, 2024 · 2 comments
Assignees
@woodruffw
Labels
enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented Apr 25, 2024 •
edited by woodruffw

Description

It would be useful if sigstore-python had a user-agent in all requests:

Current user-agent is python-requests/2.31.0. I think sigstore-python/X.Y.Z python-requests/2.31.0 (or just sigstore-python/X.Y.Z) would make sense.

This can be implemented one client at a time.
@jku jku added enhancement New feature or request good first issue Good for newcomers labels Apr 25, 2024
@woodruffw
Copy link
Member

Great idea!

@woodruffw woodruffw mentioned this issue May 9, 2024
Merged
@woodruffw woodruffw self-assigned this May 9, 2024
@woodruffw woodruffw removed the good first issue Good for newcomers label May 9, 2024
@woodruffw
Copy link
Member

Completed as of #1017, I believe 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jku @woodruffw