.github/workflows/nodejs.yml

@@ -16,25 +16,25 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [10.x, 12.x, 14.x, 16.x, 17.x, 18.x]
+        node-version: [10.x, 12.x, 14.x, 16.x, 17.x, 18.x, 19.x]
         os: [ubuntu-latest, windows-latest, macOS-latest]
 
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
       - name: Restore dependencies cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         id: cache
         with:
           path: node_modules
-          key: ${{ matrix.os }}-{{ matrix.node-version }}-node_modules-${{ hashFiles('**/package.json') }}
+          key: ${{ matrix.os }}-${{ matrix.node-version }}-node_modules-${{ hashFiles('**/package.json') }}
           restore-keys: |
-            ${{ matrix.os }}-{{ matrix.node-version }}-node_modules-
+            ${{ matrix.os }}-${{ matrix.node-version }}-node_modules-
       - name: Install Dependencies
         if: steps.cache.outputs.cache-hit != 'true'
         run: npm i

.npmrc

@@ -0,0 +1 @@
+package-lock=false

CHANGELOG.md

@@ -11,6 +11,8 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+- Increase compatibility with external build system such as `rollup` by making perf_hooks optional in gc.js
+
 ### Added
 
 ## [14.1.0] - 2022-08-23

README.md

@@ -491,21 +491,21 @@ const client = require('prom-client');
 let gateway = new client.Pushgateway('http://127.0.0.1:9091');
 
 gateway.pushAdd({ jobName: 'test' })
-	.then({resp, body} => {
+	.then(({resp, body}) => {
 		/* ... */
 	})
 	.catch(err => {
 		/* ... */
 	})); //Add metric and overwrite old ones
 gateway.push({ jobName: 'test' })
-	.then({resp, body} => {
+	.then(({resp, body}) => {
 		/* ... */
 	})
 	.catch(err => {
 		/* ... */
 	})); //Overwrite all metrics (use PUT)
 gateway.delete({ jobName: 'test' })
-	.then({resp, body} => {
+	.then(({resp, body}) => {
 		/* ... */
 	})
 	.catch(err => {
@@ -514,7 +514,7 @@ gateway.delete({ jobName: 'test' })
 
 //All gateway requests can have groupings on it
 gateway.pushAdd({ jobName: 'test', groupings: { key: 'value' } })
-	.then({resp, body} => {
+	.then(({resp, body}) => {
 		/* ... */
 	})
 	.catch(err => {

index.js

@@ -17,7 +17,8 @@ exports.Summary = require('./lib/summary');
 exports.Pushgateway = require('./lib/pushgateway');
 
 exports.linearBuckets = require('./lib/bucketGenerators').linearBuckets;
-exports.exponentialBuckets = require('./lib/bucketGenerators').exponentialBuckets;
+exports.exponentialBuckets =
+	require('./lib/bucketGenerators').exponentialBuckets;
 
 exports.collectDefaultMetrics = require('./lib/defaultMetrics');
 

lib/metrics/gc.js

@@ -14,10 +14,13 @@ const NODEJS_GC_DURATION_SECONDS = 'nodejs_gc_duration_seconds';
 const DEFAULT_GC_DURATION_BUCKETS = [0.001, 0.01, 0.1, 1, 2, 5];
 
 const kinds = [];
-kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_MAJOR] = 'major';
-kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_MINOR] = 'minor';
-kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_INCREMENTAL] = 'incremental';
-kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_WEAKCB] = 'weakcb';
+
+if (perf_hooks && perf_hooks.constants) {
+	kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_MAJOR] = 'major';
+	kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_MINOR] = 'minor';
+	kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_INCREMENTAL] = 'incremental';
+	kinds[perf_hooks.constants.NODE_PERFORMANCE_GC_WEAKCB] = 'weakcb';
+}
 
 module.exports = (registry, config = {}) => {
 	if (!perf_hooks) {
@@ -32,8 +35,7 @@ module.exports = (registry, config = {}) => {
 		: DEFAULT_GC_DURATION_BUCKETS;
 	const gcHistogram = new Histogram({
 		name: namePrefix + NODEJS_GC_DURATION_SECONDS,
-		help:
-			'Garbage collection duration by kind, one of major, minor, incremental or weakcb.',
+		help: 'Garbage collection duration by kind, one of major, minor, incremental or weakcb.',
 		labelNames: ['kind', ...labelNames],
 		buckets,
 		registers: registry ? [registry] : undefined,

lib/metrics/processHandles.js

@@ -20,8 +20,7 @@ module.exports = (registry, config = {}) => {
 
 	new Gauge({
 		name: namePrefix + NODEJS_ACTIVE_HANDLES,
-		help:
-			'Number of active libuv handles grouped by handle type. Every handle type is C++ class name.',
+		help: 'Number of active libuv handles grouped by handle type. Every handle type is C++ class name.',
 		labelNames: ['type', ...labelNames],
 		registers,
 		collect() {

lib/metrics/processRequests.js

@@ -18,8 +18,7 @@ module.exports = (registry, config = {}) => {
 
 	new Gauge({
 		name: namePrefix + NODEJS_ACTIVE_REQUESTS,
-		help:
-			'Number of active libuv requests grouped by request type. Every request type is C++ class name.',
+		help: 'Number of active libuv requests grouped by request type. Every request type is C++ class name.',
 		labelNames: ['type', ...labelNames],
 		registers: registry ? [registry] : undefined,
 		collect() {

lib/metrics/processResources.js

@@ -17,8 +17,7 @@ module.exports = (registry, config = {}) => {
 
 	new Gauge({
 		name: namePrefix + NODEJS_ACTIVE_RESOURCES,
-		help:
-			'Number of active resources that are currently keeping the event loop alive, grouped by async resource type.',
+		help: 'Number of active resources that are currently keeping the event loop alive, grouped by async resource type.',
 		labelNames: ['type', ...labelNames],
 		registers: registry ? [registry] : undefined,
 		collect() {

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "prom-client",
-	"version": "14.1.0",
+	"version": "14.1.1",
 	"description": "Client for prometheus",
 	"main": "index.js",
 	"files": [
@@ -13,9 +13,11 @@
 	},
 	"scripts": {
 		"benchmarks": "node ./benchmarks/index.js",
-		"test": "npm run lint && npm run compile-typescript && npm run test-unit",
+		"test": "npm run lint && npm run check-prettier && npm run compile-typescript && npm run test-unit",
 		"lint": "eslint .",
 		"test-unit": "jest",
+		"run-prettier": "prettier . .eslintrc",
+		"check-prettier": "npm run run-prettier -- --check",
 		"compile-typescript": "tsc --project ."
 	},
 	"repository": {
@@ -41,7 +43,7 @@
 		"jest": "^26.0.1",
 		"lint-staged": "^10.0.4",
 		"nock": "^13.0.5",
-		"prettier": "2.0.5",
+		"prettier": "2.7.1",
 		"typescript": "^4.0.2"
 	},
 	"dependencies": {
@@ -62,6 +64,7 @@
 		"useTabs": true,
 		"arrowParens": "avoid",
 		"trailingComma": "all",
+		"endOfLine": "auto",
 		"overrides": [
 			{
 				"files": "*.md",