fix: process_max_fds is process limit, not OS #314
Merged
+82
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what your CI coverage is, but I manually tested on Linux and Mac (which has no /proc). |
|
Thanks, looks good to me! Do you mind update the changelog too? Thanks! |
|
updated |
zbjornson
reviewed
Jan 24, 2020
zbjornson
approved these changes
Jan 24, 2020
|
Is there anything left for me to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #311
In case anyone is wondering why I don't check for a exact match against the ulimit output, instead of just for "reasonableness", its because there isn't really any way to check the ulimit for the current process other than reading
/proc/self/limits. Shelling out to ulimit would gives the correct value, but for the child shell... but that ulimit will be the default for /bin/sh, which might not be the ulimit for the current jest process (and is not on my machine, my login /bin/zsh has a different ulimit than /bin/sh).