Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically sort Typescript imports #1364

Closed
johnthagen opened this issue Sep 3, 2021 · 2 comments · Fixed by #1434
Closed

Automatically sort Typescript imports #1364

johnthagen opened this issue Sep 3, 2021 · 2 comments · Fixed by #1434
Assignees
@johnthagen
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
Combine Kanban
Milestone
0.7.9

Comments

@johnthagen
Copy link
Collaborator

Consider using eslint --fix to automatically sort Typescript imports to reduce the burden of this task for developers.
@johnthagen johnthagen added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Sep 3, 2021
@imnasnainaec
Copy link
Collaborator

That seems to sort by how/what you import, not where you are importing from. I think this eslint plugin is what we need:
https://www.npmjs.com/package/eslint-plugin-import

@johnthagen johnthagen self-assigned this Oct 22, 2021
@johnthagen
Copy link
Collaborator Author

I believe our usage of baseUrl in tsconfig.json is not yet supported by eslint-plugin-import:

@johnthagen johnthagen mentioned this issue Oct 22, 2021
Merged
@johnthagen johnthagen changed the title Consider ESLint to automatically sort Typescript imports Automatically sort Typescript imports Oct 22, 2021
@jasonleenaylor jasonleenaylor added this to Review in progress in Combine Kanban Oct 29, 2021
@johnthagen johnthagen added the Size: S Small sized issue label Oct 29, 2021
Combine Kanban automation moved this from Review in progress to Done Oct 29, 2021
@jasonleenaylor jasonleenaylor added this to the 0.7.9 milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnthagen johnthagen

Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
Combine Kanban
Done
Milestone
0.7.9
Development

Successfully merging a pull request may close this issue.

Enable eslint-plugin-import sillsdev/TheCombine
3 participants
@jasonleenaylor @imnasnainaec @johnthagen