Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poetry to latest version for dev and for dockerfile #238

Closed
johnml1135 opened this issue Nov 29, 2023 · 2 comments · Fixed by #249
Closed

Update poetry to latest version for dev and for dockerfile #238

johnml1135 opened this issue Nov 29, 2023 · 2 comments · Fixed by #249
Assignees

Comments

@johnml1135
Copy link
Collaborator

Do it. There was an issue that prevented updating back at poetry ~1.2. That issue is likely resolved. Let's see if it works.

@mshannon-sil
Copy link
Collaborator

I was able to upgrade to poetry version 1.7.1. The only complication is that after an experiment with poetry 1.7.1 is run on the server, experiments run by others with poetry 1.2.2 start to hang when installing poetry requirements. An issue that was very similar to this where multiple versions resulted in poetry installations hanging was resolved in poetry 1.3 (python-poetry/poetry#7137), so I'm hopeful that after everyone pulls the new version of SILNLP with poetry 1.7.1 we shouldn't run into this issue again the next time we go to upgrade poetry.

@mshannon-sil mshannon-sil linked a pull request Dec 1, 2023 that will close this issue
@johnml1135
Copy link
Collaborator Author

@mshannon-sil - changes merged. Just make sure you let everyone know (at the same time) to upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants