Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running npm install in a clean clone of this repo modifies package-lock.json #51

Closed
yokuze opened this issue Sep 3, 2019 · 2 comments
Closed

Comments

@yokuze
Copy link
Contributor

yokuze commented Sep 3, 2019

Running npm install from a clean state (e.g. right after cloning this repo) modifies the package-lock.json file, like so:

diff --git a/package-lock.json b/package-lock.json
index 4304a76..02f7223 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -3784,11 +3784,11 @@
       "dev": true,
       "requires": {
         "chalk": "^2.4.1",
-        "conventional-changelog": "^3.0.6",
-        "conventional-recommended-bump": "^4.0.4",
+        "conventional-changelog": "^3.1.2",
+        "conventional-recommended-bump": "^4.1.1",
         "detect-indent": "^5.0.0",
         "detect-newline": "^2.1.0",
-        "dotgitignore": "^1.0.3",
+        "dotgitignore": "^2.1.0",
         "figures": "^2.0.0",
         "fs-access": "^1.0.0",
         "git-semver-tags": "^2.0.2",
@yokuze
Copy link
Contributor Author

yokuze commented Sep 3, 2019

This issue is caused by the dependency on a fork of standard-version:

"standard-version": "git+https://github.com/jthomerson/standard-version.git#fix-305-header-repeat"

This fork does not contain a package-lock.json file, so when we run npm install, dependencies of this dependency are updated the latest version according to the fork's package.json file, thus changing our package-lock.json file.

This fork of standard-version was created to fix an issue that we had with standard-version that caused duplicated headers in the CHANGELOG.md output. Our PR to fix that issue has since been merged, tagged, and released. The fix is available in v6.0.0 of standard-version.

Updating to the latest version of standard-version should fix this issue.

yokuze added a commit to yokuze/eslint-config-silvermine that referenced this issue Sep 3, 2019
yokuze added a commit to yokuze/eslint-config-silvermine that referenced this issue Sep 3, 2019
@yokuze
Copy link
Contributor Author

yokuze commented Sep 3, 2019

This was fixed with #52

@yokuze yokuze closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant