Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed file sizes seem to be missing on v1.0 #297

Open
lbebber opened this issue Mar 7, 2023 · 2 comments
Open

Compressed file sizes seem to be missing on v1.0 #297

lbebber opened this issue Mar 7, 2023 · 2 comments

Comments

@lbebber
Copy link

lbebber commented Mar 7, 2023

The compressed file sizes seem to be missing on the new version. Is this intentional? Is this an issue on my side? At any rate, there are no clear instructions for enabling it on the main readme.md file.

@simonihmig
Copy link
Owner

Right. It is now using https://github.com/danvk/source-map-explorer, and while that has some support for showing gzipped sizes, that is not very good. gzip sizes are not really easy to do, as there is no definite compressed size for a single module, because only the whole bundle gets compressed, and you would need to somehow map that back to individual modules, which there is no "right" way to do. The way source-map-explorer was doing that was confusing me too much to include that.

We should at least document that for sure, and maybe provide an opt-in config?

@NullVoxPopuli
Copy link

how do you pass options directly to source-map-explorer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants