Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration fix #580

Closed
kysrpex opened this issue Feb 17, 2021 · 1 comment · Fixed by #581
Closed

Continuous integration fix #580

kysrpex opened this issue Feb 17, 2021 · 1 comment · Fixed by #581
Assignees
Labels
🐛 bug 🔨 simple fix Likely to be solvable in at most a few hours (full-time).

Comments

@kysrpex
Copy link
Contributor

kysrpex commented Feb 17, 2021

I did some research on the Bandit failure. It seems to fail because the test B322 was designed for Python 2 and Bandit dropped support for it, therefore it no longer exists. See Bandit issue PyCQA/bandit#662 .

We are running pip install bandit in the CI dockerfile, therefore I assume it was upgraded when rebuilding the image. I would fix it myself, but my version of Git Bash is too old and does not let me change the CI.

@pablo-de-andres Maybe you can do it, in .github/workflows/ci.yml, the line 20: run: bandit -r osp --skip B101,B322 needs to be replaced with run: bandit -r osp --skip B101.

@kysrpex kysrpex added 🐛 bug 🔨 simple fix Likely to be solvable in at most a few hours (full-time). labels Feb 17, 2021
@kysrpex kysrpex changed the title Continuous integration FIX Continuous integration fix Feb 17, 2021
@kysrpex
Copy link
Contributor Author

kysrpex commented Feb 18, 2021

Fixed my issue, now I am able to do it myself.

@kysrpex kysrpex assigned kysrpex and unassigned pablo-de-andres Feb 18, 2021
@kysrpex kysrpex linked a pull request Feb 18, 2021 that will close this issue
@kysrpex kysrpex closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug 🔨 simple fix Likely to be solvable in at most a few hours (full-time).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants