Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies of icons includes in releases and release notes #83

Open
mondeja opened this issue Mar 17, 2024 · 2 comments
Open

Inconsistencies of icons includes in releases and release notes #83

mondeja opened this issue Mar 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mondeja
Copy link
Member

mondeja commented Mar 17, 2024

@mondeja
Copy link
Member Author

mondeja commented Mar 17, 2024

I've manually updated release notes.

@mondeja mondeja added the bug Something isn't working label Mar 17, 2024
@LitoMore
Copy link
Member

LitoMore commented Mar 17, 2024

The Google Chronicle was added in https://cdn.jsdelivr.net/npm/simple-icons@v11.7.0/icons/googlechronicle.svg. I created this 11.8.0 release note manually; I may have missed something on my local.

Here is the code how fetching PRs:

const { data: prs } = await client.rest.pulls.list({
  owner: context.repo.owner,
  repo: context.repo.repo,
  state: 'closed',
  sort: 'updated',
  direction: 'desc',
  per_page: perPage,
  page,
});

Pull request order may changed by our comment, re-title, and other actions. Here is a similar pull request:

I think our create.js needs to be refactored. We had a conversation on our discord release-action channel. I'm checking if we can use GitHub GraphQL API to get the related PR on a commit.

For example:

query {
  repository(owner: "simple-icons", name: "simple-icons") {
    defaultBranchRef {
      target {
        ... on Commit {
          history(first: 20) {
            edges {
              node {
                oid
                message
                associatedPullRequests(first: 1) {
                  edges {
                    node {
                      title
                      url
                      number
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  }
}

@mondeja mondeja changed the title Inconsistencies of icons includes in releases and releases notes Inconsistencies of icons includes in releases and release notes Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants