Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "museum" page for discontinued brands #148

Open
jorgeamadosoria opened this issue Nov 23, 2021 · 2 comments
Open

Add "museum" page for discontinued brands #148

jorgeamadosoria opened this issue Nov 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jorgeamadosoria
Copy link
Contributor

As time passes, some brands disappear and are removed from the library. This represents a backwards compatibility problem with users that have these icons but keep their dependencies updated.

This is only an issue for brands or icons that are removed due to falling popularity or outright disappearing. Not every removal qualifies for this, for example:

  • Brands that are added by mistake or whose guidelines change after being added in such a manner as to preclude them from being used (Fedora icon, for example). In these cases a backwards break is acceptable since it would force the user to forgo a trademark violation.
  • Brands that are updated due to changing design (Google trademarks changes fairly frequently). The updated design would substitute the old one, which is a minor issue, only affecting the display of historically significant icon lists, which is not the goal of this library anyways.
  • Changes in name or slug. This will introduce a backwards compatibility issue, but since the icon is not changed nor removed, the icon won't qualify to be conserved: it's still live in the main repo.

A potential solution for this is a list page with the removed icons, similar to the existing main page but without the features for sorting or copying, etc. A minimal page would just list all removed SVGs so the user can potentially download it and use it manually or at most offer a permanent link to the latest version in which the icon can be found.

The page would have to be manually updated on each release to add the icons removed, of course.

@jorgeamadosoria jorgeamadosoria linked a pull request Dec 12, 2021 that will close this issue
@mondeja mondeja added the enhancement New feature or request label Dec 23, 2021
@jorgeamadosoria
Copy link
Contributor Author

After making a proposal in the linked PR, I think the effort necessary to automate and maintain this page is too high for the perceived benefit. As such, I'm closing this ticket as unnecessary, since no other maintainer has expressed interest in moving it forward either.

@mondeja
Copy link
Member

mondeja commented May 22, 2022

This can be rethinked if something like simple-icons/simple-icons#7437 is implemented.

@mondeja mondeja reopened this May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants