-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Add "Icon detail" view #43
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think this is becoming increasingly necessary with all we're planning to add to the project and packages; trying to display everything on the cards is going to cause too much clutter. We could, as one example, show the |
So far, i.e. with only guidelines and licenses, it is still manageable I think. With the addition of custom slugs and simple-icons/simple-icons#5002, including slugs in the card may get a bit messy. Regarding aliases, I think it depends what we want to do with those. My take (despite what is in the issue description) would be that it shouldn't affect the design of the cards much. Namely:
Any other things we're planning to add that I'm forgetting here?
Those are some interesting ideas, nice 👍 |
Is this supppaes to be a separate page or a modal? And what's the trigger, a click on the icon? I suppose that does away with the copy button. Or should both buttons be kept? We are going to need design suggestions here to proceed to coding this feature. |
I like the sidebar design in simple-icons/simple-icons#980 (comment) and I think that would be a great way to proceed. I think we can do away with the copy button and instead include that next to the download options. |
a sidebar that moves the layout of the tickets, or that slides out on top of the page? Or a fixed sidebar? I don't think I like it if it is fixed. |
I think one that slides out on top of the page would be fine. Layout shift is not ideal. |
agreed. Thank you |
ℹ️ If you're interested in this feature, please leave comment or add a 👍
Kind of issue
Description
As per this comment, add an "icon detail view". This would display a particular icon at a larger size and potentially give download options such as #31, #32, #33 for that particular icon, as seen in this example mockup.
I'm not sure how useful this is. The larger icon can be nice, but if that is the only benefit I'm not sure something like the mockup below is suitable. The icon-specific download options can be nice, but I would expect that everyone would nearly always want the same download option for all icons.
What it may allow us to do is things like:
The text was updated successfully, but these errors were encountered: