Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great Icon Review of 2024: Symbols and Numbers #10254

Closed
adamrusted opened this issue Jan 10, 2024 · 2 comments
Closed

Great Icon Review of 2024: Symbols and Numbers #10254

adamrusted opened this issue Jan 10, 2024 · 2 comments
Assignees
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both

Comments

@adamrusted
Copy link
Member

adamrusted commented Jan 10, 2024

This Issue is to track all icons that start with a symbol or number. We encourage contributors to let us know of any icons we've missed as part of this scope in the comments below this issue. They will be added to the list below by the maintainers.

Table of Contents

Checking Icons

For each icon in our collection, the following steps need to be carried out. Once you identify an icon that needs updating, please comment below this issue with details and we'll add it to the table below.

  1. Does the brand still exist?
  2. Is it still within our scope?
  3. Have they rebranded?
  4. If they haven't, does our icon line up exactly with the source?
  5. Even if it does, are there any improvements that can be made to our existing icon (e.g., reducing precision, or removing excess points)?
  6. Is our hex colour correct?
  7. Are our source & guidelines URLs still valid?
  8. Does the guidelines URL actually include brand guidelines?
  9. Are we conforming to all available branding or trademark guidelines?
  10. Are we using the correct license?
  11. Are there any branding or trademark guidelines, or a license available that should be added?

Icons Identified

Icon Identified by Change Required Tackle in PR Contributor
.ENV @adamrusted Change source URL to meet our criteria JSON Updates @adamrusted
.NET @adamrusted Change source URL to meet our criteria JSON Updates @adamrusted
/e/ @adamrusted Identify new source, update SVG to match. #10269 @PeterShaggyNoble
1001Tracklists @adamrusted Update icon to match SVG on homepage. #10260 @PeterShaggyNoble
1Password @PeterShaggyNoble Update source, colour & SVG, and add guidelines. #10256 @PeterShaggyNoble
3M @PeterShaggyNoble None n/a n/a
42 @adamrusted Update icon to match SVG on homepage. #10278 @PeterShaggyNoble
4chan @PeterShaggyNoble None n/a n/a
4D @PeterShaggyNoble None n/a n/a
500px @adamrusted Update icon to match SVG on homepage, update colour. #10270 @PeterShaggyNoble
7Zip @PeterShaggyNoble None (recently added) #7334 @PeterShaggyNoble
99designs @PeterShaggyNoble None (recently added) #9987 @PeterShaggyNoble
9GAG @PeterShaggyNoble None (recently added) #8329 @ripzerotwo

Pull Requests

This is how we recommend our contributors split up the pull requests required to close this issue. We encourage anybody, even new contributors, to assist with these Great Icon Reviews.

JSON Updates

This PR should only contain updates to the _data/simple-icons.json file.

Dealt with in #10255

Icon Change Required Done?
.ENV Change source URL to meet our criteria ✔️
.NET Change source URL to meet our criteria ✔️

JSON & Icon Updates

This PR should only contain updates where both the JSON and the icon have changed.

Icon Change Required Done?
/e/ Identify new source, update SVG to match. ✔️
1001Tracklists Update icon to match SVG on homepage. ✔️
1Password Update source, colour & SVG, and add guidelines. ✔️
42 Update icon to match SVG on homepage. ✔️
500px Update icon to match SVG on homepage, update colour. ✔️

Removals

This PR should only contain removal of icons. Remember to delete both the JSON entry and the SVG.

Icon Change Required Done?
@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jan 10, 2024
@adamrusted adamrusted changed the title Great Icon Review of 2024: 0-9 Great Icon Review of 2024: Symbols and Numbers Jan 10, 2024
@PeterShaggyNoble PeterShaggyNoble pinned this issue Jan 10, 2024
@PeterShaggyNoble
Copy link
Member

A note on 4D: Although our version doesn't line up exactly with the logo on their website, it was contributed by an official representative (see #3407 (comment)).

This was referenced Jan 10, 2024
@PeterShaggyNoble PeterShaggyNoble added the good first issue Issues we believe are simple and a good first stab at contributing to the project label Jan 11, 2024
This was referenced Jan 11, 2024
@adamrusted
Copy link
Member Author

Moving onto #10282.
Thanks for your help on this @PeterShaggyNoble!

@adamrusted adamrusted unpinned this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

No branches or pull requests

3 participants
@adamrusted @PeterShaggyNoble and others