New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Linux Deepin icon #1495
Added Linux Deepin icon #1495
Conversation
Can you elaborate on which official SVG you are talking about? I haven't been able to find any on the deepin website. Also they seem to use lowercase "deepin" when referring to the operating system, with "Deepin" being used for any related name (see e.g. deepin Wiki: "Visit the Deepin Community Download Page to download the latest deepin ISO/Live System.") |
The svg I took from the distro itself (is the one I use) and only adapted to the standard. This is the symbol of the distro, without the tiny deepin as you have observed. |
If you want to know more information about deepin https://www.deepin.org/en/aboutus/ |
In that case, can you update the source in |
update made |
Do I need to do anything else in this pr? |
I'm personally not sure about the name. I agree with @birjolaxew that it seems the distro name is 'deepin' (with a lowercase 'd', see also Wikipedia: "Deepin (stylized as deepin; [...]") but everywhere else it is Deepin (with a uppercase 'D', e.g. Deepin Technologies). So the question really is, do we add the icons as belonging to the distro or to the organization, as far as I can tell they both use the same logo... 🤔 Either way, the name will have to be updated... Do you have something to say about this @JoaoPedromoraes? Any other opinions @birjolaxew and @davidklebanoff? |
I think "deepin", lowercase, is the most appropriate, since it's often stylized as such when referencing the distro, which I believe is more popular than the Deepin organization itself. |
I would like to merge pr, what do I still need to do? |
Sorry @JoaoPedromoraes, it looks like this PR got put on pause as we were trying to get consensus on the icon name. My vote is "deepin", for reasons mentioned above. What are your votes @ericcornelissen, @birjolaxew? |
@davidklebanoff I agree with you - when talking about the distro, it seems that "deepin" is what they use. |
I do not know why it is not passing the test, could you clarify the error? |
@JoaoPedromoraes It's because the |
solved problem |
👍 Looks good! Thanks for your work on this, especially fixing the (minor) issues we had. Your work is much appreciated! |
Issue: #1160
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
From the official SVG I was able to create a monocolor version. https://www.deepin.org/en/