Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Linux Deepin icon #1495

Merged
merged 4 commits into from Aug 23, 2019
Merged

Added Linux Deepin icon #1495

merged 4 commits into from Aug 23, 2019

Conversation

joaopedromoraez
Copy link
Contributor

Issue: #1160

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

From the official SVG I was able to create a monocolor version. https://www.deepin.org/en/

@birjj
Copy link
Contributor

birjj commented Jun 28, 2019

Can you elaborate on which official SVG you are talking about? I haven't been able to find any on the deepin website.

Also they seem to use lowercase "deepin" when referring to the operating system, with "Deepin" being used for any related name (see e.g. deepin Wiki: "Visit the Deepin Community Download Page to download the latest deepin ISO/Live System.")

@birjj birjj added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed new icon Issues or pull requests for adding a new icon labels Jun 28, 2019
@joaopedromoraez
Copy link
Contributor Author

Você pode explicar em qual SVG oficial você está falando? Eu não consegui encontrar nenhum no site da deepin.

Além disso, eles parecem usar minúsculas "deepin" quando se referem ao sistema operacional, com "Deepin" sendo usado para qualquer nome relacionado (veja, por exemplo, deepin Wiki : "Visite a página de download da Deepin Community para baixar o mais recente sistema Deepin ISO / Live". )

The svg I took from the distro itself (is the one I use) and only adapted to the standard. This is the symbol of the distro, without the tiny deepin as you have observed.

@joaopedromoraez
Copy link
Contributor Author

If you want to know more information about deepin https://www.deepin.org/en/aboutus/
and where can we find the logo on svg https://commons.wikimedia.org/wiki/File:Deepin_logo.svg

@ericcornelissen
Copy link
Contributor

If you want to know more information about deepin https://www.deepin.org/en/aboutus/
and where can we find the logo on svg https://commons.wikimedia.org/wiki/File:Deepin_logo.svg

In that case, can you update the source in simple-icons.json to the Wikimedia URL?

@joaopedromoraez
Copy link
Contributor Author

Se você quiser saber mais informações sobre deepin https://www.deepin.org/en/aboutus/
e onde podemos encontrar o logotipo em svg https://commons.wikimedia.org/wiki/File:Deepin_logo.svg

Nesse caso, você pode atualizar a fonte simple-icons.jsonpara o URL da Wikimedia?

update made

@joaopedromoraez
Copy link
Contributor Author

Do I need to do anything else in this pr?

@ericcornelissen
Copy link
Contributor

Do I need to do anything else in this pr?

I'm personally not sure about the name. I agree with @birjolaxew that it seems the distro name is 'deepin' (with a lowercase 'd', see also Wikipedia: "Deepin (stylized as deepin; [...]") but everywhere else it is Deepin (with a uppercase 'D', e.g. Deepin Technologies). So the question really is, do we add the icons as belonging to the distro or to the organization, as far as I can tell they both use the same logo... 🤔

Either way, the name will have to be updated... Do you have something to say about this @JoaoPedromoraes? Any other opinions @birjolaxew and @davidklebanoff?

@davidklebanoff
Copy link
Contributor

I think "deepin", lowercase, is the most appropriate, since it's often stylized as such when referencing the distro, which I believe is more popular than the Deepin organization itself.

@davidklebanoff davidklebanoff removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 18, 2019
@joaopedromoraez
Copy link
Contributor Author

I would like to merge pr, what do I still need to do?

@davidklebanoff
Copy link
Contributor

Sorry @JoaoPedromoraes, it looks like this PR got put on pause as we were trying to get consensus on the icon name. My vote is "deepin", for reasons mentioned above. What are your votes @ericcornelissen, @birjolaxew?

@birjj
Copy link
Contributor

birjj commented Aug 22, 2019

@davidklebanoff I agree with you - when talking about the distro, it seems that "deepin" is what they use.

@joaopedromoraez
Copy link
Contributor Author

I do not know why it is not passing the test, could you clarify the error?

@birjj
Copy link
Contributor

birjj commented Aug 22, 2019

@JoaoPedromoraes It's because the "title": "deepin" in the JSON and the <title>Deepin icon</title> don't match - to fix it you'll just need to update it to <title>deepin icon</title> :)

@joaopedromoraez
Copy link
Contributor Author

solved problem

@birjj birjj merged commit e435e53 into simple-icons:develop Aug 23, 2019
@birjj
Copy link
Contributor

birjj commented Aug 23, 2019

👍 Looks good! Thanks for your work on this, especially fixing the (minor) issues we had. Your work is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants