Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket.io Icon Added #1583

Merged
merged 4 commits into from Aug 14, 2019
Merged

Socket.io Icon Added #1583

merged 4 commits into from Aug 14, 2019

Conversation

fatihmeh
Copy link
Contributor

@fatihmeh fatihmeh commented Aug 9, 2019

Issue: #1564

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Svg file taken from main site https://socket.io/css/images/logo.svg
Color is taken from svg logo file

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the SVG should be socket-dot-io.svg (that's just how we translate brand names to filenames) and then the build should succeed as well 👍 I also want a small change to the source URL, but other than that the Pull Request looks good 😄

_data/simple-icons.json Outdated Show resolved Hide resolved
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Aug 10, 2019
fatihmeh and others added 3 commits August 13, 2019 13:58
Socket.io source updated

Co-Authored-By: Eric Cornelissen <ericornelissen@gmail.com>
@ericcornelissen ericcornelissen merged commit 0663005 into simple-icons:develop Aug 14, 2019
@fatihmeh fatihmeh deleted the socket branch August 14, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants