Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would love a C and C sharp icon #1693

Closed
kchateau opened this issue Oct 3, 2019 · 9 comments
Closed

Would love a C and C sharp icon #1693

kchateau opened this issue Oct 3, 2019 · 9 comments
Assignees
@PokiDokika
Labels
new icon Issues or pull requests for adding a new icon

Comments

@kchateau
Copy link

kchateau commented Oct 3, 2019

Name:
Website:
Official resources for icon and color:
@kchateau kchateau added the new icon Issues or pull requests for adding a new icon label Oct 3, 2019
@nil3sh99
Copy link

Name: C and C++ icon
Official Resource:

  1. C++ - https://www.dropbox.com/s/yyg1hqo4ndbjmlz/C%2B%2B.svg?dl=0
  2. C - https://www.dropbox.com/s/pxf4aszkoor5pfn/C-Programming.svg?dl=0

@ericcornelissen
Copy link
Contributor

Thanks @nil3sh99, where did you find those?

@nil3sh99
Copy link

Hey @ericcornelissen , i took a lil help from svg icons and modified them to suit the needs of website.

@ericcornelissen
Copy link
Contributor

i took a lil help from svg icons

I'm sorry but I'm not quite sure what you mean @nil3sh99?

@PokiDokika PokiDokika mentioned this issue Oct 23, 2019
Merged
3 tasks
@el1f
Copy link
Contributor

el1f commented Oct 28, 2019

The C logo proposed in this issue seems to be an alteration of the the C++ logo endorsed by Standard C++, you can find it being used on the ISO website for C++.
It seems like the correct C logo has been already added by @PokiDokika anyways so that's great.
The water's a little muddier with the C# logo. There seems to be no actual official logo for C# as referred in this stackoverflow question and this issue in another repo which seems to leave us with two possibilities regarding which logo to use: this one, which uses the C++ style and has been featured on seeveral other websites or this other one which is being used in Wikipedia.

I am open to vectorizing the one that we decide to end up using.

@PokiDokika
Copy link
Contributor

@el1f I submitted a c logo that was based off the c++ logo, but everyone wanted me to remake it in the style of the K&R book. I still have the original if you wish to have it.

@ericcornelissen
Copy link
Contributor

@PokiDokika that is correct, the related discussion can be found in that Pull Request for anyone interested. As for the C# logo, you can follow the progress in #1807 @el1f.

All in all, this issues does not need any contributions at the moment (i.e. the C logo has been added and the C# logo has an open Pull Request).

@el1f
Copy link
Contributor

el1f commented Oct 28, 2019

I didn't bring my point home in the previous comment. I agree on the decision to use the K&R logo for C and the current version of the C++ logo. My point was mostly about the addition of the C# logo but I didn't realize that there's already an open PR for that. I apologize for the misunderstanding

ericcornelissen pushed a commit that referenced this issue Nov 8, 2019
@alisen @ericcornelissen
Add C# (#1807)
e7db809 
* Add C# (#1693)

* Created csharp.svg

* I added Csharp data

* role attribute added to svg

* Circle update

* Data updated
@ericcornelissen
Copy link
Contributor

With #1807 for C# merged now (and #1819 C earlier) I will close this issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PokiDokika PokiDokika

Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ericcornelissen @el1f @kchateau @nil3sh99 @PokiDokika