New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Eyeem Icon #1788
Added Eyeem Icon #1788
Conversation
I'll need to change something, because i messed up the "expo.svg" image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngrosso Thanks for the contribution!
We generally prefer to source our SVGs from as close to the official source as we can get it. In this case the official EyeEm website actually uses an SVG in their header (namely https://www.eyeem.com/node-static/img/logos/eyeem-text.svg - although the fill is white, so it might not show up if you open it in your browser).
Unfortunately it looks like the SVG you have in this PR differs slightly from the official SVG:
Could you please update the PR to use the official SVG instead?
Everything else looks good to me though.
Sure i'll take a look on tuesday, thanks for pointing it out |
👍 Looks good! Thanks a lot for the contribution @ngrosso! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure if #000000
is an appropriate brand colour. Yes the logo seem so be used in black, but their site uses #191919
instead. Judging by the screenshots of their apps I would say they use that/a similarly not-quite-black colour as well (e.g. this for Android and this for iOS).
That said, if the other @simple-icons/maintainers think it should be #000000
I'm fine with that as well (given that their apps also use a lot of seemingly #000000
) and this can be merged in as is.
I think |
I agree with @phatbhoy67 that #000000 is the appropriate color here. Thanks a lot for the contribution @ngrosso! |
Issue: #1550
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Got icon from Svgrepo
Got hex from EyeEm press kit
Checked the image with inkscape