Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Eyeem Icon #1788

Merged
merged 6 commits into from Nov 3, 2019
Merged

Added Eyeem Icon #1788

merged 6 commits into from Nov 3, 2019

Conversation

ngrosso
Copy link
Contributor

@ngrosso ngrosso commented Oct 16, 2019

Issue: #1550

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Got icon from Svgrepo
Got hex from EyeEm press kit
Checked the image with inkscape

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 17, 2019
@ngrosso
Copy link
Contributor Author

ngrosso commented Oct 18, 2019

I'll need to change something, because i messed up the "expo.svg" image

Copy link
Contributor

@birjj birjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngrosso Thanks for the contribution!

We generally prefer to source our SVGs from as close to the official source as we can get it. In this case the official EyeEm website actually uses an SVG in their header (namely https://www.eyeem.com/node-static/img/logos/eyeem-text.svg - although the fill is white, so it might not show up if you open it in your browser).
Unfortunately it looks like the SVG you have in this PR differs slightly from the official SVG:

Could you please update the PR to use the official SVG instead?

Everything else looks good to me though.

@ngrosso
Copy link
Contributor Author

ngrosso commented Oct 19, 2019

Sure i'll take a look on tuesday, thanks for pointing it out

@ngrosso ngrosso requested a review from birjj October 22, 2019 18:47
@birjj
Copy link
Contributor

birjj commented Oct 22, 2019

👍 Looks good! Thanks a lot for the contribution @ngrosso!

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure if #000000 is an appropriate brand colour. Yes the logo seem so be used in black, but their site uses #191919 instead. Judging by the screenshots of their apps I would say they use that/a similarly not-quite-black colour as well (e.g. this for Android and this for iOS).

That said, if the other @simple-icons/maintainers think it should be #000000 I'm fine with that as well (given that their apps also use a lot of seemingly #000000) and this can be merged in as is.

@phatbhoy67
Copy link
Contributor

I think #000000 is the main colour I would associate with this brand. 🎨

@birjj birjj merged commit faeff0a into simple-icons:develop Nov 3, 2019
@birjj
Copy link
Contributor

birjj commented Nov 3, 2019

I agree with @phatbhoy67 that #000000 is the appropriate color here. #191919 seems to be their website nav color, but #000000 is used extensively on both their website and for the brand in general.

Thanks a lot for the contribution @ngrosso!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants