Spectrum logo

[RodolfoBrian]

Issue:

Checklist

• I updated the JSON data in _data/simple-icons.json
• I optimized the icon with SVGO or SVGOMG
• The SVG viewbox is 0 0 24 24

Description

[RodolfoBrian]

it been approved. i don't see any issue here.

[birjj]

Thanks a lot for the work @RodolfoBrian! Unfortunately it looks like this PR doesn't quite follow our contribution guidelines. Namely:

• The "hex" values should be fully uppercase. Currently the value for Mojang contains lowercase letters.
• The entries in simple-icons.json should be ordered alphabetically.
• The SVGs should be named in such a way that they match the brand names - in this case mojang.svg and spectrum.svg. We do not support having two SVGs for a single brand (as you have for Spectrum here)
• The SVGs should be updated to match our contribution guidelines. This means resizing it to a 24x24 viewbox (with the logo taking up as much space as possible), making it monochrome, converting it to a single <path>, optimizing it and annotating it as described
• It is unclear to me which "Spectrum" is being added here, and the source URL does not help much. Could you please describe it a bit more? Judging from the SVG, it also looks like the brand color for Spectrum is a purple-ish color, not #000000

Could you please have a look through our guidelines and update the PR to match?

[ericcornelissen]

@RodolfoBrian your PR still requires changes already pointed out previously by @birjolaxew. Please read their comments and be sure to let us know if you have any questions.

[birjj]

@RodolfoBrian Almost there! Only a few minor changes left before this is ready to merge:

• As @ericcornelissen pointed out, the JSON is currently malformed due to an extra comma at the end. You can go to the files tab and click "Add suggestion to batch" on each of his suggested changes, before finally clicking the "Commit suggestions (2)" that pops up - that way his suggestions will be applied without you having to mess with Git all over again.

• One of our requirements is that the logo takes up as much of the 24x24 viewbox as possible - could you resize the logo so that it has a height or a width of 24 (or in this case the logo looks square, so a height and a width of 24)?

• It looks like the brand writes their name as "Spectrum", while this PR currently has name set to "spectrum". Could you update it with the correct capitalization?

• This PR currently has the brand color set to #FFFFFF. It looks like their brand uses a purple color as their primary identifying color instead - specifically #7B16FF, if their favicon is to be trusted. Could you update the color too?

[RodolfoBrian]

@RodolfoBrian Almost there! Only a few minor changes left before this is ready to merge:

• As @ericcornelissen pointed out, the JSON is currently malformed due to an extra comma at the end. You can go to the files tab and click "Add suggestion to batch" on each of his suggested changes, before finally clicking the "Commit suggestions (2)" that pops up - that way his suggestions will be applied without you having to mess with Git all over again.
• One of our requirements is that the logo takes up as much of the 24x24 viewbox as possible - could you resize the logo so that it has a height or a width of 24 (or in this case the logo looks square, so a height and a width of 24)?
• It looks like the brand writes their name as "Spectrum", while this PR currently has name set to "spectrum". Could you update it with the correct capitalization?
• This PR currently has the brand color set to #FFFFFF. It looks like their brand uses a purple color as their primary identifying color instead - specifically #7B16FF, if their favicon is to be trusted. Could you update the color too?

Thank you for your explanation is much clear now.

[ericcornelissen]

Thank you for your explanation is much clear now.

Thank you for the updates @RodolfoBrian, good work 👍 Could you update the SVG so that the logo touches the edges of the viewbox (4 if the logo fits perfectly into a square without distorting it, and 2 otherwise) as well?

[birjj]

👍 Looks good! Thanks a lot for all your work on updating this @RodolfoBrian and @ericcornelissen!