Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojang icon (simple-icons#1708) #1818

Merged
merged 4 commits into from Oct 23, 2019
Merged

Mojang icon (simple-icons#1708) #1818

merged 4 commits into from Oct 23, 2019

Conversation

reginareynolds
Copy link
Contributor

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The hex value is the color value of the logo. I checked the Mojang website for any design documents, but the official source linked in #1708 was only about the terms and conditions of using the logo.

@birjj
Copy link
Contributor

birjj commented Oct 23, 2019

Thanks a lot for the PR!

It actually looks like the header at mojang.com contains an SVG; the website itself is no longer used, but it looks like the logo is the current one. It looks like the Mojang logo in this PR is their older logo, which has some very slight differences from their current one (namely sharper "spikes"). Could you update the source and SVG to match the official version?

@birjj birjj added changes requested new icon Issues or pull requests for adding a new icon labels Oct 23, 2019
@reginareynolds
Copy link
Contributor Author

@birjolaxew You're right, the logo off of mojang.com is perfectly square while the previous version is ever so slightly rectangular. The shades of red are also slightly different. I updated the image source and the hex value to reflect the new source .svg. I've also updated the icon based off of the new image source

@birjj birjj merged commit 70f490a into simple-icons:develop Oct 23, 2019
@birjj
Copy link
Contributor

birjj commented Oct 23, 2019

👍 Great to hear! Thanks for the speedy update and the work put into this PR, we appreciate it a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants