Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C Programming Language #1819

Merged
merged 6 commits into from Oct 24, 2019
Merged

C Programming Language #1819

merged 6 commits into from Oct 24, 2019

Conversation

PokiDokika
Copy link
Contributor

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I picked the hex value because the C++ logo (which is really similar to the C logo) uses it. I found the vectorized logo from dropbox (I found the link from issue #1693) and I decided to make it usable for this project. This is my first attempt to do anything in inkscape so I hope that it'll be good enough.

@birjj
Copy link
Contributor

birjj commented Oct 23, 2019

This is a tough issue to start off with, because it requires a bit of judgement on which logo to pick ;)

The good news is that the SVG looks pretty good! There are some minor problems (e.g. the logo looks to be a bit more than 24pt high - did you resize using the toolbar which lets you input the size directly?) and a misspelling in the name of the JSON which is causing the build to fail, but we'll let that rest for now - thanks a lot for otherwise following our contribution guidelines! It means a lot.

The more pressing problem that we'll have to figure out is what the "official" logo of the C programming language is. This is a bit harder than e.g. C++ which has Standard C++ as an authority, or C# which has Microsoft as an authority - I don't think that C really has a an authority that uses a logo. As far as I can tell, two logos have become popular: the logo of the K&R book, and then the one used in this PR (which apparently is based on the C++ one?).

I think it's difficult to really decide on one to pick. For my money, I'm fine with the version used in this PR. It does not, however, have an official resource, which is kind of unique in Simple Icons. Any thoughts on this @simple-icons/maintainers?

@birjj birjj added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed new icon Issues or pull requests for adding a new icon labels Oct 23, 2019
@ericcornelissen
Copy link
Contributor

Although I'm personally fine with the version in the Pull Request (and the SVG looks great, good job @PokiDokika!), I do think that the "K&R" version can be consider "official" as the book it comes from is (co)written by (according to the Wikipedia page for C) the "creator" of the language.

One other thing is that I think the name should be just "C" rather then "C Programming Language" (also, there is a type in "language" in the JSON data file) since we don't use the "Programming Language" suffix for any other programming language.

@phatbhoy67
Copy link
Contributor

phatbhoy67 commented Oct 24, 2019

I think that wikipedia version might be a better source, which can also give users confidence and a future reference point. Using a logo derivative from a language derivative to represent the parent would be strange in my opinion.

The version in the PR: "This C Programming icon is made in flat color style. This format was developed by Icons8 designer team and became immensely popular for use in web and mobile applications." 🤔

@PokiDokika
Copy link
Contributor Author

Sorry about misnaming it and all!
I hope that it works now.
Thank you for your feedback!

@birjj
Copy link
Contributor

birjj commented Oct 24, 2019

@phatbhoy67 I think that quote refers to the style. It is also written on e.g. their touchpad icon.

That being said, it looks like the consensus is to use the logo of the K&R book for C instead of the version in this PR. Could you please update the SVG @PokiDokika?

@birjj birjj added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Oct 24, 2019
@PokiDokika
Copy link
Contributor Author

I updated the SVG to match the one on the K&R book.
I hope that it's what you're looking for.

@birjj birjj requested a review from phatbhoy67 October 24, 2019 15:16
@ericcornelissen ericcornelissen merged commit 6e61a5f into simple-icons:develop Oct 24, 2019
@ericcornelissen
Copy link
Contributor

Thanks for your contribution and cooperation on this icon @PokiDokika 🎉

@PokiDokika
Copy link
Contributor Author

No problem! I'm happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants