Add Apache Spark icon (#1329) #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that we would prefer using the orange from the logo as their color. Their website is predominantly blue, but I think the brand itself is mostly connected to the orange of the star in their wordmark. Thoughts @ericcornelissen? |
|
Its a tough choice but I personally associate orange with Spark more than blue. It's an easy change later on so I think it is fine if we go with orange for now 馃憤 |
|
Hey @ericcornelissen @birjolaxew I've updated the hex value to |
|
馃憤 Looks good! Thanks a lot for your work on the vector and this PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Issue: #1329 **
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Extracted broken "star" from from official wordmark logo. The wikipedia version is converted from the official .eps version.
Manually edited to complete "star" by following the "V" made from the "k" in "Spark" to match the favicon.
Predominant brand colour used on Apache Spark website is blue, chosen hex value
#2FA4E7as it appears to be the colour most used (changed my mind 馃槅).Built on GitPod, working as expected.