add roundcube icon #1821
Merged
add roundcube icon #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR @jmmendivil, this is an excellent monochromization and good details in the PR description! We'd also like to say thanks for following our contribution guidelines, that is something we appreciate a lot. The only minor thing I'd like changed before merging this in is that the brand seems to style their name as "Roundcube" when it's written in text, while this PR uses "roundcube" - could you update this PR to use the official capitalization (both in the JSON and in the |
birjj
approved these changes
Oct 24, 2019
|
👍 Thanks a lot for the update @jmmendivil, and for all your work on this! This will be included in the next release :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1619
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Created custom shapes based on one from the discussion because the actual logo don't work on monochromatic.
Primary color based on the blue one from the original logo.