New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spring icon #1706 #1822
add spring icon #1706 #1822
Conversation
Hey @bgalek, thanks a lot for the PR! A few things we'd like changed before we can merge this in:
|
Hi @birjolaxew! |
Thanks a lot for the update! The checklist in our PR template doesn't quite cover everything our contribution guidelines do; we used to have a lot of new contributors that either submitted SVGs directly from the source, without minifying/resizing it, or didn't update the JSON correctly - the checklist is mostly used as a reminder to contributors that we have some formatting requirements, even if it doesn't cover all of them (although it might be time to update it ;) ). Thanks a lot for reading the contribution guidelines regardless! That does mean a lot to us. One last thing that I apparently missed in my last comment: I'm getting |
It's possible that I messed with it during vectorization process, I'll update the color! :) |
👍 That is all the nitpicking I could do this time around I think ;) The vectorization looks excellent. Thanks a lot for the updates and all your work on this @bgalek! |
Issue:
#1706 add spring icon (spring.io)
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description