Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mozilla Firefox icon #1825

Merged
merged 2 commits into from Oct 27, 2019

Conversation

foo-dogsquared
Copy link
Contributor

Issue: #1824

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

There is an official monochrome version offered from the asset pack in their logo usage guide.
The SVG from the asset pack is pretty optimized and only needs scaling to fit the Simple Icons specs.

As for the color update, I chose it from their color design guide.

The chosen color is based from the pictured hues from the official palette.

Screenshot_2019-10-25 Home - Mozilla Dot Design

Initially, I have chosen four colors: the middle two variants of each hue.

Here are the hex values for easy referencing: #FFBD4F, #FFA537, #FE8A4F, and #FF7139.
As you can see from the pull request, I ended up with #FF7139 since I feel it is the closest color to the updated colors to the original.

@ericcornelissen ericcornelissen added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Oct 25, 2019
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update 👌 I agree with your choice of colour (it being close to the old colour seems like a good measure to me) but because of its ambiguity I will leave it to one of the other @simple-icons/maintainers to merge.

I simply forgot to update it with the rest. Whoops.
@birjj birjj merged commit c7683cc into simple-icons:develop Oct 27, 2019
@foo-dogsquared foo-dogsquared deleted the mozilla-firefox-update branch October 28, 2019 03:39
@birjj birjj mentioned this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants