New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hitachi icon #1846
Add Hitachi icon #1846
Conversation
This looks good to me! Just for clarity, could you describe where you got the SVG from? I can only seem to find raster versions on their website. |
I got the SVG from the Wikimedia commons here. |
@el1f In that case, could you please update the |
Oh, you're right about that. Still, I think this is a grey area when it comes to how to approach this change: What do you think about it? |
@el1f While the I see your point that an eventual rebrand would reach Wikimedia with a bit of a delay, but I think that in this case the need to source the vector itself trumps that. Thoughts @simple-icons/maintainers? |
I agree with @birjolaxew, though as @el1f said it is (it almost always is) a gray area. But I think the Wikimedia link is more helpful for the project in this case. Hence, @el1f once you update the To the argument that the Wikimedia link is not going to tell us whether the brand details are outdated I would say that neither does a link to the website. If a brand is outdated we usually find out through contributions (be it from contributors or maintainers) rather then from someone going through the URLs in the metadata file and checking if everything is still up-to-date. |
Done! :) |
👍 Thanks for your work on this @el1f! |
Issue: #1671
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Got the color hex from the website as the design document I found here seems to be set in CMYK mode and has a slightly different hue than the one used in digital media.