Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hitachi icon #1846

Merged
merged 2 commits into from Nov 1, 2019
Merged

Add Hitachi icon #1846

merged 2 commits into from Nov 1, 2019

Conversation

el1f
Copy link
Contributor

@el1f el1f commented Oct 28, 2019

Issue: #1671

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Got the color hex from the website as the design document I found here seems to be set in CMYK mode and has a slightly different hue than the one used in digital media.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 28, 2019
@birjj
Copy link
Contributor

birjj commented Oct 29, 2019

This looks good to me! Just for clarity, could you describe where you got the SVG from? I can only seem to find raster versions on their website.

@birjj birjj added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Oct 29, 2019
@el1f
Copy link
Contributor Author

el1f commented Oct 29, 2019

I got the SVG from the Wikimedia commons here.
As you can see their website only has the PNGs so I compared that version with the one used in their website, realized it was a perfect match and went on with that

@birjj
Copy link
Contributor

birjj commented Oct 29, 2019

@el1f In that case, could you please update the "source" to the Wikimedia page? Since this looks good other than that, I'll get this merged in afterwards :)

@el1f
Copy link
Contributor Author

el1f commented Oct 29, 2019

Oh, you're right about that. Still, I think this is a grey area when it comes to how to approach this change:
The source in Readme is referred to as a link to a document that will enable to realize whether or not the current icon is representative of the brand. In this case the Wikimedia isn't helpful because if Hitachi goes through a rebrand that link isn't going to be useful to understand that the logo is outdated, nor is it going to provide an updated resource to the new logo.

What do you think about it?

@birjj
Copy link
Contributor

birjj commented Oct 31, 2019

@el1f While the "source" URL is mostly used so we can go back later and find updated versions of the logo, should it ever change, it also gives an idea of how official the logo source is (e.g. whether it's an official vector, a vector taken from Wikimedia, or a manual vectorization of an official raster). In this case the Wikimedia link further includes some important information about where the vector comes from (it appears to be an officially published PDF, where the logo has been extracted from).

I see your point that an eventual rebrand would reach Wikimedia with a bit of a delay, but I think that in this case the need to source the vector itself trumps that. Thoughts @simple-icons/maintainers?

@birjj birjj added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Oct 31, 2019
@ericcornelissen
Copy link
Contributor

I agree with @birjolaxew, though as @el1f said it is (it almost always is) a gray area. But I think the Wikimedia link is more helpful for the project in this case.

Hence, @el1f once you update the "source" to the Wikimedia page we can merge this 😃

To the argument that the Wikimedia link is not going to tell us whether the brand details are outdated I would say that neither does a link to the website. If a brand is outdated we usually find out through contributions (be it from contributors or maintainers) rather then from someone going through the URLs in the metadata file and checking if everything is still up-to-date.

@ericcornelissen ericcornelissen added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Oct 31, 2019
@el1f
Copy link
Contributor Author

el1f commented Oct 31, 2019

Done! :)

@birjj birjj merged commit 76cf7cf into simple-icons:develop Nov 1, 2019
@birjj
Copy link
Contributor

birjj commented Nov 1, 2019

👍 Thanks for your work on this @el1f!

@birjj birjj mentioned this pull request Nov 3, 2019
@el1f el1f deleted the hitachi branch December 9, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants