Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Ads logo #1848

Merged
merged 2 commits into from Oct 31, 2019
Merged

Add Google Ads logo #1848

merged 2 commits into from Oct 31, 2019

Conversation

el1f
Copy link
Contributor

@el1f el1f commented Oct 29, 2019

Issue: #1676

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

ads
Here it is. Opinions?

@birjj
Copy link
Contributor

birjj commented Oct 29, 2019

This looks good to me! I like the monochromization you've done here a lot (and thanks for the work!), but given that that's a subjective thing, I'll let another @simple-icons/maintainers merge this in.

@birjj birjj added the new icon Issues or pull requests for adding a new icon label Oct 29, 2019
@el1f
Copy link
Contributor Author

el1f commented Oct 29, 2019

TBF that's for the better. I realized that there actually happens to be a monochromatic version of the Ads logo on the Google MyBusiness dashboard. You can see it in the attached screenshot.
Which one should we use?

image

@birjj
Copy link
Contributor

birjj commented Oct 29, 2019

@el1f If there is an official monochrome version, we'd definitely prefer using that one. Good find! If you update the PR, I'll get this merged in.

@el1f
Copy link
Contributor Author

el1f commented Oct 29, 2019

I will go ahead and try to either extract it directly from there or trace it if it's not an SVG. Will update you tomorrow morning

@el1f
Copy link
Contributor Author

el1f commented Oct 30, 2019

Done @birjolaxew

@birjj
Copy link
Contributor

birjj commented Oct 31, 2019

👍 Thansk a lot @el1f!

@birjj birjj merged commit 045f948 into simple-icons:develop Oct 31, 2019
@el1f el1f deleted the googleads branch October 31, 2019 08:51
@birjj birjj mentioned this pull request Nov 3, 2019
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jan 18, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants