Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft Teams icon #1858

Merged
merged 4 commits into from Oct 31, 2019
Merged

Add Microsoft Teams icon #1858

merged 4 commits into from Oct 31, 2019

Conversation

bonez0607
Copy link
Contributor

@bonez0607 bonez0607 commented Oct 29, 2019

Issue: #1261

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  1. Hex Value: #2B579A based on the main branding color used on Microsoft Teams page

  2. Logo adjusted based on the feedback provided in issue Microsoft Teams Icon #1261 - where option 2 appeared to be the most popular

@foo-dogsquared foo-dogsquared added the new icon Issues or pull requests for adding a new icon label Oct 30, 2019
_data/simple-icons.json Outdated Show resolved Hide resolved
@foo-dogsquared
Copy link
Contributor

I've missed checking the source somehow.
Could you simply change the source to https://docs.microsoft.com/media/logos/logo_MSTeams.svg (as referenced from the related issue).
My apologies for the mistake. 😅

After that, I'll merge this PR in.

@bonez0607
Copy link
Contributor Author

@foo-dogsquared Eagles eyes over here! Great catch, I've updated the source as requested 😄

@foo-dogsquared
Copy link
Contributor

Nice!
Thanks again for your work, @bonez0607 !
It is much appreciated to the maintainers.

@foo-dogsquared foo-dogsquared merged commit 3577f95 into simple-icons:develop Oct 31, 2019
@bonez0607 bonez0607 deleted the microsoft-teams branch October 31, 2019 16:15
@birjj birjj mentioned this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants