Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overleaf icon #1862

Merged
merged 1 commit into from Oct 31, 2019
Merged

Add Overleaf icon #1862

merged 1 commit into from Oct 31, 2019

Conversation

foo-dogsquared
Copy link
Contributor

Issue: #1861

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Brand color is extracted from the SVGs linked in the media resources page.

@birjj
Copy link
Contributor

birjj commented Oct 31, 2019

👍 Looks good! Thanks for taking care of this one @foo-dogsquared!

@birjj birjj merged commit 36fdd55 into simple-icons:develop Oct 31, 2019
@birjj
Copy link
Contributor

birjj commented Oct 31, 2019

I noticed just after merging that the "source" URL here seems to be a direct link to their favicon SVG. Since they are nice enough to provide an actual logo page, with official SVG download, I think we'd prefer using that as the source. I've pushed 281c19a directly to develop (instead of reverting this PR, updating it and re-merging) to update this. Feel free to revert if any @simple-icons/maintainers disagree with this decision.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 31, 2019
@birjj birjj mentioned this pull request Nov 3, 2019
@foo-dogsquared foo-dogsquared deleted the overleaf branch June 22, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants