Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notion icon #1867

Merged
merged 2 commits into from Oct 31, 2019
Merged

Add Notion icon #1867

merged 2 commits into from Oct 31, 2019

Conversation

bonez0607
Copy link
Contributor

Issue: #1866

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  1. Hex Value: #000000 - selected from the logo itself. The website is also black and white. I didn't see a primary brand color located in their media kit

  2. Logo icon was taken from home page header bar via svg-grabber.

@birjj
Copy link
Contributor

birjj commented Oct 31, 2019

Thanks a lot for grabbing this one! It's a bit weird that the SVG in their media kit is actually a PNG embedded in an SVG, but as you point out they luckily have an actual SVG in their website header. The color used on their website is #040402, but the PNG from their media kit uses #000000 so I am perfectly fine with using that.

The only change I'd ask for is to update the "source" URL to just https://www.notion.so/. This is probably the first time I'm asking to udpate it away from an official media kit, but considering that their media kit SVG isn't actually SVG, I think using the page with the SVG is preferable.

@birjj birjj added the new icon Issues or pull requests for adding a new icon label Oct 31, 2019
@bonez0607
Copy link
Contributor Author

Sounds good - will update this when I get back to my comp

@birjj birjj merged commit 228a8e6 into simple-icons:develop Oct 31, 2019
@birjj
Copy link
Contributor

birjj commented Oct 31, 2019

👍 Thanks for the update, and for taking care of this one!

@birjj birjj mentioned this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants