Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMC Software icon #1900

Merged
merged 3 commits into from Nov 26, 2019
Merged

Conversation

foo-dogsquared
Copy link
Contributor

@foo-dogsquared foo-dogsquared commented Nov 9, 2019

Issue: #1673

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The vector and color was extracted from the header logo of the website.
More specifically, it is from this link.

EDIT: Nevermind, I found the logo usage guide.
It seems that they preferred to keep the logo and the wordmark.
I don't see a rule that allows the symbol to be used exclusively.
What do you think?

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Nov 9, 2019
@birjj
Copy link
Contributor

birjj commented Nov 14, 2019

Hmm, there's no obvious choice to make here. It looks like they use the full BMC wordmark fairly consistently, barring a few cases where the full wordmark wouldn't fit (e.g. their favicon). On the other hand, it could be argued that our icons are likely to be used exactly in those cases. Without any explicit guiding by the brand itself, it'll have to be a judgement call. Thoughts @simple-icons/maintainers?

@birjj birjj added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 14, 2019
@birjj
Copy link
Contributor

birjj commented Nov 26, 2019

Pinging other @simple-icons/maintainers again for opinions.

@phatbhoy67
Copy link
Contributor

Hey @birjolaxew sorry about the late reply, looking at the brand guideline the full logo is made up of a symbol and logotext. In most cases we isolate and extract the symbol, so I think that is what we should do again in this case.

@birjj
Copy link
Contributor

birjj commented Nov 26, 2019

Aight, let's remove the wordmark then. Could you update the SVG @foo-dogsquared?

@birjj birjj added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Nov 26, 2019
@foo-dogsquared
Copy link
Contributor Author

The SVG has been updated (or rather reverted to its original commit), @birjolaxew .

Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @foo-dogsquared 👍

@birjj birjj merged commit 1124892 into simple-icons:develop Nov 26, 2019
@foo-dogsquared foo-dogsquared deleted the bmc-software branch November 27, 2019 03:30
birjj added a commit that referenced this pull request Dec 10, 2019
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants