Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Smugmug icon #1918

Merged
merged 3 commits into from Nov 30, 2019
Merged

Add Smugmug icon #1918

merged 3 commits into from Nov 30, 2019

Conversation

PeterShaggyNoble
Copy link
Member

Issue: #1891
SmugMug

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Colour was retrieved from website's stylesheet

@phatbhoy67 phatbhoy67 added the new icon Issues or pull requests for adding a new icon label Nov 14, 2019
@phatbhoy67
Copy link
Contributor

Hey @PeterShaggyNoble excellent work on the .svg 👍 , thanks for your work on this PR.

Happy to merge this one in if we can get to a consensus on the hex value.

The colour is definitely a green. However, there seems to be a few choices available.

You picked #6eb800, which is used on the front page of their site as the background colour for the search icon and as the text colour (:hover) value on some a elements. The icon .pngs on the front page also use this colour. I also found #7FCE69, #2ecc71 in other places.

Looking at the files, the .eps (for print) uses #62be32 for the logo, the .psd (for web) uses #6db944 for the logo. The .png files for web use #6db800 on the one with black text and #6db944 on the one with white text. 🙀

What do the @simple-icons/maintainers think? 🤔

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Nov 14, 2019 •
edited

Well, that's fun! I'd lean towards #6db944 but only because it's the only one that appears on the list twice.

#7fce69 & #2ecc71 are too different, visually from what's used in the logo so I'd eliminate them, at least.

@birjj
Copy link
Contributor

birjj commented Nov 20, 2019

I'd agree with #6DB944, although that is rather arbitrary. They don't seem super consistent in their color usage, so we probably shouldn't sweat it - but I still would prefer using a color from their logos, rather than their website. Could you update @PeterShaggyNoble?

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Nov 26, 2019 •
edited

To confirm, @phatbhoy67 & @birjolaxew: We're agreed on #6db944, correct?

If so, I'll get this updated in the morning (GMT).

@birjj
Copy link
Contributor

birjj commented Nov 26, 2019

@PeterShaggyNoble Yes, sorry for the confusing wording. #6DB944 would be my preferred color.

@PeterShaggyNoble
Copy link
Member Author

Colour updated.

(Wasn't expecting such a quick reply!)

@phatbhoy67
Copy link
Contributor

Thanks for your work on this one @PeterShaggyNoble 👍

@phatbhoy67
Copy link
Contributor

Thanks for your work on this one @PeterShaggyNoble 👍

@phatbhoy67 phatbhoy67 merged commit 5de78eb into simple-icons:develop Nov 30, 2019
@phatbhoy67 phatbhoy67 mentioned this pull request Nov 30, 2019
Closed
@PeterShaggyNoble PeterShaggyNoble deleted the smugmug branch December 2, 2019 10:53
@ericcornelissen ericcornelissen mentioned this pull request Dec 8, 2019
Merged
birjj added a commit that referenced this pull request Dec 10, 2019
@birjj
Merge pull request #2105 from simple-icons/develop
4fb6330 
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterShaggyNoble @phatbhoy67 @birjj