New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SonarLint icon (#1453) #1946
Conversation
Looks like they stylize their name as "SonarLint", while this PR uses "sonarlint". I'd probably also prefer if the source URL was the GitHub repo, since the PNG isn't easily available from their website. Since this is a manual vectorization, I'll let another @simple-icons/maintainers merge this in once it's been updated. |
Pinging other @simple-icons/maintainers again for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably also prefer if the source URL was the GitHub repo, since the PNG isn't easily available from their website.
Any reason the source URL was not updated? I agree with @birjolaxew on that one 🤔
Other than that this looks good to me as well 👍 Good work @phatbhoy67
Hey @ericcornelissen @birjolaxew, I completely missed that part sorry. 😿 The repo (https://github.com/SonarSource/sonarlint-website/) has been archived (might have missed that before 😮) and as the favicon is available in the source of the website itself (https://www.sonarlint.org/favicon-152.png), should I leave it as it is or update it? 🤔 |
I think that they might've archived it because they do not want issues and pull requests on it. I'd suspect that, should they ever update their brand, they might unarchive and update it. Since it also links to the website, I'd personally prefer the repo. Thoughts @simple-icons/maintainers? |
👍 Thanks for updating it @phatbhoy67! No obvious good solution here, but what can you do ¯\_(ツ)_/¯ |
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1). New icons: - Fiverr (#1978) - ResearchGate (#1980) - Formstack (#1983) - EPEL (#1942) - SonarQube (#1943) - SonarCloud (#1944) - SonarSource (#1945) - LLVM (#1958) - Linode (#1981) - W3C (#1990) - OpenAPI Initiative (#1994) - React Router (#1995) - repl.it (#1996) - Internet Archive (#1977) - styled-components (#1970) - Invoice Ninja (#1948) - PrestaShop (#1969) - BMC Software (#1900) - Square (#2006) - Loop (#2011) - PJSIP (#2018) - Trustpilot (#2008) - Smugmug (#1918) - Blackberry (#1927) - Imgur (#1988) - OBS Studio (#2009) - Datacamp (#2016) - Steinberg (#2015) - SVGO (#2001) - Gutenberg (#2014) - GNU IceCat (#2017) - SonarLint (#1946) - BandLab (#2013) - Tailwind (#2010) - Pocket Casts (#2029) - Workplace (#2021) - Academia (#2026) - Fossil SCM (#2036) - Breaker (#2028) - Brandfolder (#2035) - Accusoft (#2031) - F-Droid (#2039) - XDA-Developers (#2020) - PeerTube (#2033) - Curl (#2012) - write.as (#2007) - RabbitMQ (#2052) - iTunes (#2019) - QuickTime (#2066) - 1password (#2030) - Wish (#2044) - Reason Studios (#2054) - Apache Kafka (#2060) - Fossa (#2041) - Dolby (#2081) - Amazon Alexa (#2072) - IcoMoon (#2074) - Deliveroo (#2077) - Home Assistant (#2088) - Hypothesis (#2089) - Trend Micro (#2090) - OpenID (#2091) - Teradata (#2092) - Microsoft Office (#2093) - LastPass (#2083) - Quip (#2046) Updated icons: - Sublime Text (#1975) - Deezer (#2005) - Facebook (#2047) - Uber (#2048) - Yahoo! (#2097) Removed icons: - Google Allo (6ac966f) - Lanyrd (6ac966f)
Issue: #1453
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Manual vector of official source .png.
Hex value
#cc2026
is from the logo.Built on GitPod, working as expected.