Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM icon (#1936) #1958

Merged
merged 4 commits into from Nov 26, 2019
Merged

Add LLVM icon (#1936) #1958

merged 4 commits into from Nov 26, 2019

Conversation

phatbhoy67
Copy link
Contributor

@phatbhoy67 phatbhoy67 commented Nov 20, 2019

Issue: #1936

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Manual vector silhouette of the wyvern (type of dragon) in the official logo .png.

Official source .ai converted to .svg.

The logo mainly #252c38 and many grey silvers including #c9ced4.

Hex value chosen, #252C38, is from the dragon wings in the full logo.

Hex value the color of the text in this derivative image: (https://llvm.org/img/LLVM-Logo-Derivative-5.png)

Built on Gitpod, working as expected.

@h1nk
Copy link

h1nk commented Nov 21, 2019

I'm not too sure about the color. Because the wings are a gradient, perhaps #262D3A would be better. It's taken from the color of the text in this and this image, or maybe instead #556293 which was taken from this and this.

I'd say probably the darker one (#262D3A) though because it's closer to the average gradient color of the wings in the main logo.

@h1nk
Copy link

h1nk commented Nov 21, 2019

Also, it might be better to make the silhouette paths based off of the official Illustrator file rather than doing it manually from the raster image.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Nov 22, 2019
@phatbhoy67
Copy link
Contributor Author

I'm not too sure about the color.

Hey @hink the diff in rgb values between the colour you picked and the one I chose from the gradient are approx ±1 on each channel 👀 Spooky 👻
#252C38
#262D3A
I'll be honest, I can't really tell them apart visually. Happy to update the PR all the same 😸

@h1nk
Copy link

h1nk commented Nov 23, 2019

the diff in rgb values between the colour you picked and the one I chose from the gradient are approx ±1 on each channel

Haha, I only noticed the last channel was different.

Happy to update the PR all the same

Yeah, I think updating the color to the one pulled from the text and taking the silhouette path from the official vector instead of manual rasterization would be best.

@phatbhoy67
Copy link
Contributor Author

updating the color to the one pulled from the text

🎉 Done

@birjj
Copy link
Contributor

birjj commented Nov 26, 2019

👍 Thanks for your work on this @phatbhoy67, and your reviewing of it @h1nk!

@birjj birjj merged commit 6a74ecf into simple-icons:develop Nov 26, 2019
@phatbhoy67 phatbhoy67 deleted the llvm branch November 26, 2019 01:01
birjj added a commit that referenced this pull request Dec 10, 2019
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants