Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Internet Archive (#1967) #1977

Merged
merged 2 commits into from Nov 26, 2019
Merged

Conversation

runxel
Copy link
Member

@runxel runxel commented Nov 23, 2019

Issue:
Closes #1967

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

See Issue.

@runxel runxel changed the title Add Internet Archive Add Internet Archive (#1967) Nov 23, 2019
@phatbhoy67 phatbhoy67 added the new icon Issues or pull requests for adding a new icon label Nov 24, 2019
@foo-dogsquared
Copy link
Contributor

The resulting SVG looks pretty off - specifically on the columns of the logo - as seen in the attached image.

2019-11-25-00-30-14

For context, it's just two vectors (yours and the vector from the suggested source) with different colors (pink and green, respectively) overlaid on top on each other.

IDK how it became different so I advice to double-check if you are indeed using the source to create the SVG.

@runxel
Copy link
Member Author

runxel commented Nov 24, 2019

The resulting SVG looks pretty off - specifically on the columns of the logo - as seen in the attached image.
IDK how it became different so I advice to double-check if you are indeed using the source to create the SVG.

Huh, that is indeed really odd. I just took it from the source linked in the issue and did not modify it at all. I would blame it on SVGOMG for the moment – I have no other explanation.
Thanks for noticing, I will have a look :)

@runxel
Copy link
Member Author

runxel commented Nov 25, 2019

So it turns out I ran into an Illustrator bug/edge case.
I had to redraw the columns in the logo with less points (no problem here, the original had already way to many), otherwise the SVG output would be dented.

@foo-dogsquared
Copy link
Contributor

Nicely done, @runxel !
The improvements looking good to me.

Many thanks for your contributions as well! :)

@foo-dogsquared foo-dogsquared merged commit 855d3cd into simple-icons:develop Nov 26, 2019
@runxel runxel deleted the archive branch November 26, 2019 19:47
birjj added a commit that referenced this pull request Dec 10, 2019
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internet Archive (digital library)
3 participants