Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResearchGate (#1912) #1980

Merged
merged 3 commits into from Nov 25, 2019
Merged

Conversation

runxel
Copy link
Member

@runxel runxel commented Nov 23, 2019

Issue:
Closes #1912

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

See Issue.
Data taken from official svg favicon.

@runxel runxel changed the title Add ResearchGate Add ResearchGate (#1912) Nov 23, 2019
@phatbhoy67 phatbhoy67 added the new icon Issues or pull requests for adding a new icon label Nov 24, 2019
@phatbhoy67
Copy link
Contributor

Hey @runxel, thanks for taking on this PR.

The checks failed due to a typo in your .json entry:

"title": "ResarchGate",

should be
"title": "ResearchGate",

Looking at the .svg, it is a black rounded square with no letters, I think something has gone wrong. See below:

scrnli_25_11_2019_16-09-15

Can you update please.

@phatbhoy67 phatbhoy67 added changes requested awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Nov 25, 2019
@phatbhoy67 phatbhoy67 removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Nov 25, 2019
@phatbhoy67
Copy link
Contributor

Thanks @runxel for the quick fix 👏 merging this is one in.

@phatbhoy67 phatbhoy67 merged commit 82c517e into simple-icons:develop Nov 25, 2019
@runxel runxel deleted the researchgate branch November 25, 2019 18:21
birjj added a commit that referenced this pull request Dec 10, 2019
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

researchgate icon is missing
2 participants