Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write.as icon (#2003) #2007

Merged
merged 4 commits into from Dec 3, 2019
Merged

Conversation

runxel
Copy link
Member

@runxel runxel commented Nov 28, 2019

Issue:
Closes #2003

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

see issue :)

@phatbhoy67 phatbhoy67 added the new icon Issues or pull requests for adding a new icon label Nov 28, 2019
@phatbhoy67
Copy link
Contributor

Hey @runxel thanks for working on this PR 👍

The hex value you chose in the PR is #00B3E3, referenced in #2003 as the blue colour in the logo dot.

I get the colour of the dot to be #5bc4ee 🤔

@phatbhoy67 phatbhoy67 added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 28, 2019
@runxel
Copy link
Member Author

runxel commented Nov 29, 2019

@phatbhoy67
Yeah, you're right. The culprit.

Anyway. It's fixed! Thanks for the catch!

@PeterShaggyNoble
Copy link
Member

They use #5bc4ee in https://write.as/img/w-sq.svg and #00b3e3 in https://write.as/img/writeas-logo.svg

@phatbhoy67 phatbhoy67 removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 30, 2019
@phatbhoy67
Copy link
Contributor

Hey @runxel the .svg is good 👍 , however, as @PeterShaggyNoble points out, there seems to be a bit of a choice of blue to use as the hex value so I will ask the opinion of the @simple-icons/maintainers on this point.

Can you please change the source to be (https://write.as/brand).

All logo options, including (https://write.as/img/w-sq.svg), can be found on that page (and another shade of blue #5ac4ee).

@runxel
Copy link
Member Author

runxel commented Nov 30, 2019

Updated the link. Thanks for the valuable comments here!
At the brand page they only use #5ac4ee – sadly they don't explicitly mention it.
However I would go with that one.

@birjj
Copy link
Contributor

birjj commented Dec 1, 2019

I think the blue #5bc4ee (the current on in the PR) is good enough for me. Based on https://write.as/brand, it seems to be what's used in their official logomark, with #00b3e3 being from their full wordmark. Given that they aren't consistent themselves, I don't think we have to fuss too much, but I would probably use the one from the logomark.

If other @simple-icons/maintainers agree, I think this is ready to merge.

@ericcornelissen ericcornelissen merged commit 12579e8 into simple-icons:develop Dec 3, 2019
@runxel runxel deleted the write.as branch December 4, 2019 10:39
birjj added a commit that referenced this pull request Dec 10, 2019
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add write.as
5 participants