Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iTunes icon (previously abandoned) #2019

Merged
merged 1 commit into from Dec 4, 2019
Merged

Add iTunes icon (previously abandoned) #2019

merged 1 commit into from Dec 4, 2019

Conversation

runxel
Copy link
Member

@runxel runxel commented Nov 28, 2019

Issue:
get #1096 (abandoned) going again

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@runxel
iTunes icon
b604349 
get simple-icons#1096 (abandoned) going again
@PeterShaggyNoble
Copy link
Member

Was going to add this last week but then thought it might be covered by Apple Music. Perhaps not!

@runxel
Copy link
Member Author

runxel commented Nov 29, 2019

Was going to add this last week but then thought it might be covered by Apple Music. Perhaps not!

You're right, they are pretty similar, yet not the same. (I did miss that Apple Music was already on board)
I let the maintainers decide :)

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Nov 30, 2019
@birjj
Copy link
Contributor

birjj commented Dec 1, 2019

I couldn't find any official guidelines on the actual iTunes logo. The Apple Music guidelines (which uses a similar logo) specifically forbids using the circle version, but that seems to be for Apple Music app; the iTunes Store guidelines uses the app icon, which is significantly different from the logo of iTunes itself.

Thoughts @simple-icons/maintainers?

@phatbhoy67
Copy link
Contributor

The icon used on iTunes homepage is the one below, so I think the PR version is the correct one to use here. As previously mentioned, similar but not the same as Apple Music so I think adding it is a good idea.

iTunes Logo

@birjj
Copy link
Contributor

birjj commented Dec 4, 2019

👍 In that case this looks good. Thanks for reopening and taking care of this @runxel!

@birjj birjj merged commit c63e781 into simple-icons:develop Dec 4, 2019
@runxel runxel deleted the itunes branch December 4, 2019 18:27
@ericcornelissen ericcornelissen mentioned this pull request Dec 8, 2019
Merged
birjj added a commit that referenced this pull request Dec 10, 2019
@birjj
Merge pull request #2105 from simple-icons/develop
4fb6330 
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@runxel @PeterShaggyNoble @birjj @phatbhoy67