Add XDA-Developers icon #2020
Merged
Add XDA-Developers icon #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @PeterShaggyNoble thanks for taking this one on, the .svg is great. 👍 I can't see anywhere the dash is used i.e. "XDA-Developers" other than in the site url, so I think it should just be "XDA Developers". Can you update the title in the .svg file, the filename and the .json entry please. |
|
I was going by the |
|
Hey @PeterShaggyNoble thanks for the quick reply. Can you also update .svg file with This will remove the linting error causing the check to fail. 🎉 |
|
Ah-ha! That's what I was missing! Updated. Thanks, @phatbhoy67. |
|
Thanks for your work on this one @PeterShaggyNoble appreciated 👍 |
phatbhoy67
added a commit
that referenced
this pull request
Dec 2, 2019
This reverts commit c44f9f1.
birjj
added a commit
that referenced
this pull request
Dec 10, 2019
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1). New icons: - Fiverr (#1978) - ResearchGate (#1980) - Formstack (#1983) - EPEL (#1942) - SonarQube (#1943) - SonarCloud (#1944) - SonarSource (#1945) - LLVM (#1958) - Linode (#1981) - W3C (#1990) - OpenAPI Initiative (#1994) - React Router (#1995) - repl.it (#1996) - Internet Archive (#1977) - styled-components (#1970) - Invoice Ninja (#1948) - PrestaShop (#1969) - BMC Software (#1900) - Square (#2006) - Loop (#2011) - PJSIP (#2018) - Trustpilot (#2008) - Smugmug (#1918) - Blackberry (#1927) - Imgur (#1988) - OBS Studio (#2009) - Datacamp (#2016) - Steinberg (#2015) - SVGO (#2001) - Gutenberg (#2014) - GNU IceCat (#2017) - SonarLint (#1946) - BandLab (#2013) - Tailwind (#2010) - Pocket Casts (#2029) - Workplace (#2021) - Academia (#2026) - Fossil SCM (#2036) - Breaker (#2028) - Brandfolder (#2035) - Accusoft (#2031) - F-Droid (#2039) - XDA-Developers (#2020) - PeerTube (#2033) - Curl (#2012) - write.as (#2007) - RabbitMQ (#2052) - iTunes (#2019) - QuickTime (#2066) - 1password (#2030) - Wish (#2044) - Reason Studios (#2054) - Apache Kafka (#2060) - Fossa (#2041) - Dolby (#2081) - Amazon Alexa (#2072) - IcoMoon (#2074) - Deliveroo (#2077) - Home Assistant (#2088) - Hypothesis (#2089) - Trend Micro (#2090) - OpenID (#2091) - Teradata (#2092) - Microsoft Office (#2093) - LastPass (#2083) - Quip (#2046) Updated icons: - Sublime Text (#1975) - Deezer (#2005) - Facebook (#2047) - Uber (#2048) - Yahoo! (#2097) Removed icons: - Google Allo (6ac966f) - Lanyrd (6ac966f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1931
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
They use the
xdafor their favicon as well as their app icons. Colour was taken from website logo.