Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add F-Droid (#2037) #2039

Merged
merged 1 commit into from Dec 2, 2019
Merged

Add F-Droid (#2037) #2039

merged 1 commit into from Dec 2, 2019

Conversation

runxel
Copy link
Member

@runxel runxel commented Dec 1, 2019

Issue:
Closes #2037

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The logo comes from the svg in their website header. The blue color #1976D2 is from the droid's body (and also mainly used on the website, that's why I chose it over the green tone).
The stenciling of the copyleft symbol was done to stay compatible to other monochrome versions, like at Fork Awesome. (Endorsed by the maintainers of F-Droid)

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Dec 2, 2019
@phatbhoy67
Copy link
Contributor

Hey @runxel thanks for your work on this 👍

The stenciling of the copyleft symbol was done to stay compatible to other monochrome versions, like at Fork Awesome. (Endorsed by the maintainers of F-Droid)

Looking at the official .svg the PR version is quite different. See image below. "Exp" = "Expected"
f-droid-comp

I see you have really looked into this issue which is great.👍

However, reading the reference you included (ForkAwesome/Fork-Awesome#135) you conclude "endorsed", whereas I read that as an acknowledgment this action would simply be compliant with the license terms? 🤔

Even so, I'm not convinced an interpretation of the design is appropriate when there is an official source .svg? What do the @simple-icons/maintainers think?

simplified .svg code below ⬇️ for "Exp" in above .png ⬆️

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24"><path d="M.68.153a.662.662 0 00-.067.002.662.662 0 00-.469 1.072l2.239 2.9c-.274.453-.44.98-.44 1.55v.88c0 1.663 1.338 3 3 3h14.114c1.662 0 3-1.337 3-3v-.88c0-.57-.165-1.097-.439-1.55l2.238-2.9a.662.662 0 00-.554-1.072.662.662 0 00-.493.263L20.69 3.163a2.988 2.988 0 00-1.633-.487H4.943c-.603 0-1.161.18-1.63.485L1.19.418A.662.662 0 00.68.153zM6.905 4.66a1.786 1.786 0 011.786 1.785 1.786 1.786 0 01-1.786 1.787A1.786 1.786 0 015.12 6.446a1.786 1.786 0 011.787-1.785zm10.321 0a1.786 1.786 0 011.787 1.785 1.786 1.786 0 01-1.787 1.787 1.786 1.786 0 01-1.785-1.787 1.786 1.786 0 011.785-1.785zM4.943 10.087c-1.662 0-3 1.338-3 3v7.76c0 1.662 1.338 3 3 3h14.114c1.662 0 3-1.338 3-3v-7.76c0-1.662-1.338-3-3-3zM12 11.409a5.566 5.566 0 015.56 5.557A5.567 5.567 0 0112 22.525a5.566 5.566 0 01-5.557-5.559A5.564 5.564 0 0112 11.41zm0 1.006a4.544 4.544 0 00-4.553 4.551A4.546 4.546 0 0012 21.52a4.546 4.546 0 004.553-4.553A4.544 4.544 0 0012 12.416zm0 1.244a3.32 3.32 0 013.31 3.307A3.321 3.321 0 0112 20.275a3.322 3.322 0 01-3.22-2.567h1.67c.274.581.858.979 1.55.979.96 0 1.721-.761 1.721-1.72 0-.96-.761-1.72-1.72-1.72a1.7 1.7 0 00-1.493.873H8.807A3.321 3.321 0 0112 13.66z"/></svg>

@birjj
Copy link
Contributor

birjj commented Dec 2, 2019

@phatbhoy67 I definitely agree that we should use the official SVG.

@runxel
Copy link
Member Author

runxel commented Dec 2, 2019

Appreciating the comment @phatbhoy67!
But I think something's wrong on your side. The icon in the PR is the one you have linked.
Your version is way to round, the one in the PR is 100% true to the original. I've checked it thrice now and I'm pretty sure that I've done everything carefully... 😕

Maybe you have resized the logo and by accident the Illustrator option "resize corners and effects" was on? Because again, look at the official logo: (sorry for dark mode)
fd

The corners are rounded, but the radius is much much smaller than in your "EXP" version.

@runxel runxel added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 2, 2019
@birjj
Copy link
Contributor

birjj commented Dec 2, 2019 •
edited

After checking it out in Illustrator, I can definitely confirm that the version from this PR matches the official SVG exactly.

With that in mind, I'll be merging this in. Thanks for your work on this @runxel!

@birjj birjj merged commit 4b92ba8 into simple-icons:develop Dec 2, 2019
@birjj birjj removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 2, 2019
@birjj
Copy link
Contributor

birjj commented Dec 2, 2019

Also I'm kinda interested in what went wrong above :P It's obviously an honest mistake, but I'm having a hard time trying to think of how the SVG got more rounded. Would be interested if you figure it out @phatbhoy67.

@phatbhoy67
Copy link
Contributor

f-droid-final

Update...................

@runxel runxel deleted the fdroid branch December 2, 2019 15:34
@runxel
Copy link
Member Author

runxel commented Dec 2, 2019

Also I'm kinda interested in what went wrong above :P It's obviously an honest mistake, but I'm having a hard time trying to think of how the SVG got more rounded.

My bets are still on the Illustrator option that will resize rounded corners when scaling (or rather not resizes so the radius stays big, but the overall vector sizes down). 🤔

@phatbhoy67
Copy link
Contributor

As @runxel pointed out I think it was a scaling issue with the stroke when I copied one into the other to compare and resized down the original icon to 24px. I'd love to tell you it's an easy mistake to make, but it really isn't 😆 Apologies for the spam @runxel

@runxel
Copy link
Member Author

runxel commented Dec 2, 2019

Ah don't worry @phatbhoy67! Happens to the best people! 😊

@ericcornelissen ericcornelissen mentioned this pull request Dec 8, 2019
Merged
birjj added a commit that referenced this pull request Dec 10, 2019
@birjj
Merge pull request #2105 from simple-icons/develop
4fb6330 
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add F-Droid
3 participants
@runxel @phatbhoy67 @birjj