Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuickTime icon #2066

Merged
merged 5 commits into from Dec 4, 2019
Merged

Add QuickTime icon #2066

merged 5 commits into from Dec 4, 2019

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Dec 4, 2019

QuickTime
Issue: #1935

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Very uncertain about pretty much everything in this (see #1935 for more details) so could do with some input from the @simple-icons/maintainers.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Dec 4, 2019
@birjj
Copy link
Contributor

birjj commented Dec 4, 2019

The SVG itself looks pretty on point, except that the corners of the official version seems to be slightly rounded, while they're sharp in this PR.

I personally think I would prefer a blue for the color. I think that the primary color of the official logo is the blue center, which also matches well with the blue of the old logo. It's obviously a gradient (and a raster image) so it's hard to pick one color, but I think one of #17D5FB or #1C69F0 would work (those are taken from the lightest part and the part just above the center respectively).

@PeterShaggyNoble
Copy link
Member Author

That's some eyesight you have, @birjolaxew! 😆 Leave it with me, I'll see if I can tweak that.

Personally, of the 2 blues, I'd lean towards the darker one.

@PeterShaggyNoble
Copy link
Member Author

Does this look a bit closer, @birjolaxew?

QuickTime

@birjj
Copy link
Contributor

birjj commented Dec 4, 2019

@PeterShaggyNoble That looks good! Thanks for updating it. I agree that the darker of the two blues is probably the way to go, so once that's been updated we'll get this merged in :)

@PeterShaggyNoble
Copy link
Member Author

Thanks for the help, @birjolaxew - those changes have been made.

@birjj
Copy link
Contributor

birjj commented Dec 4, 2019

👍 Looks good! Since the color is pretty subjective, I'll let another @simple-icons/maintainers weigh in on whether we should use blue or black before merging this in.

Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me #1C69F0 looks pretty darn good!
I'd always think of blue rather than black if someone says Quicktime.

@birjj birjj merged commit d9b7e06 into simple-icons:develop Dec 4, 2019
@PeterShaggyNoble PeterShaggyNoble deleted the quicktime branch December 4, 2019 14:22
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Dec 4, 2019
birjj added a commit that referenced this pull request Dec 10, 2019
New version number `v2.0.0`, closes [the related Milestone](https://github.com/simple-icons/simple-icons/milestone/1).

New icons:

- Fiverr (#1978)
- ResearchGate (#1980)
- Formstack (#1983)
- EPEL (#1942)
- SonarQube (#1943)
- SonarCloud (#1944)
- SonarSource (#1945)
- LLVM (#1958)
- Linode (#1981)
- W3C (#1990)
- OpenAPI Initiative (#1994)
- React Router (#1995)
- repl.it (#1996)
- Internet Archive (#1977)
- styled-components (#1970)
- Invoice Ninja (#1948)
- PrestaShop (#1969)
- BMC Software (#1900)
- Square (#2006)
- Loop (#2011)
- PJSIP (#2018)
- Trustpilot (#2008)
- Smugmug (#1918)
- Blackberry (#1927)
- Imgur (#1988)
- OBS Studio (#2009)
- Datacamp (#2016)
- Steinberg (#2015)
- SVGO (#2001)
- Gutenberg (#2014)
- GNU IceCat (#2017)
- SonarLint (#1946)
- BandLab (#2013)
- Tailwind (#2010)
- Pocket Casts (#2029)
- Workplace (#2021)
- Academia (#2026)
- Fossil SCM (#2036)
- Breaker (#2028)
- Brandfolder (#2035)
- Accusoft (#2031)
- F-Droid (#2039)
- XDA-Developers (#2020)
- PeerTube (#2033)
- Curl (#2012)
- write.as (#2007)
- RabbitMQ (#2052)
- iTunes (#2019)
- QuickTime (#2066)
- 1password (#2030)
- Wish (#2044)
- Reason Studios (#2054)
- Apache Kafka (#2060)
- Fossa (#2041)
- Dolby (#2081)
- Amazon Alexa (#2072)
- IcoMoon (#2074)
- Deliveroo (#2077)
- Home Assistant (#2088)
- Hypothesis (#2089)
- Trend Micro (#2090)
- OpenID (#2091)
- Teradata (#2092)
- Microsoft Office (#2093)
- LastPass (#2083)
- Quip (#2046)

Updated icons:

- Sublime Text (#1975)
- Deezer (#2005)
- Facebook (#2047)
- Uber (#2048)
- Yahoo! (#2097)

Removed icons:

- Google Allo (6ac966f)
- Lanyrd (6ac966f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants