Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Yammer #2558

Merged
merged 3 commits into from Mar 6, 2020
Merged

Update Yammer #2558

merged 3 commits into from Mar 6, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Yammer

Issue: #1585

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

See #2541 for notes on source URL

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Feb 7, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Feb 7, 2020
Closed
@ericcornelissen
Copy link
Contributor

The "Y" has some weird angles to it but it seems the source material does too 🤔 I'm fine with adding it this way but I'll request a second pair of 👀 from another @simple-icons/maintainers just in case 👍

@runxel
Copy link
Member

runxel commented Feb 14, 2020

It looks weird, yes, but not toooo shoddy.
I think we can add this.

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Feb 14, 2020 •
edited

Now that it's been pointed out, it's annoying me! 😆 But beyond my limited skills to try to fix! 🙁

@runxel
Copy link
Member

runxel commented Feb 14, 2020

Hey @PeterShaggyNoble!
I can totally understand the pain :D

What do you think of this?

yammer

It's totally redrawn, has much less control points, and straight lines are actually straight. (And of course you would see differences if you do an overlay – but that's clearly expected and a mudged origin can never yield a totally equal looking constructed svg)

@PeterShaggyNoble
Update Yammer icon
1cd3453 
With thanks to @runxel
@PeterShaggyNoble
Copy link
Member Author

Appreciate that, thanks @runxel 😀

Your version was just a hair over 24px wide and scaling down to size required increasing the precision to 4 when running it through SVGOMG.

@runxel
Copy link
Member

runxel commented Feb 21, 2020

Your version was just a hair over 24px wide and scaling down to size required increasing the precision to 4 when running it through SVGOMG.

Ach, that reminds me to check my svgs more careful after I svgo them. Precision 3 is indeed not always sufficient...

ericcornelissen
ericcornelissen approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interpretation looks just fine, nice work @runxel 👌 And also thanks @PeterShaggyNoble for the initial work 😄

@ericcornelissen ericcornelissen merged commit 803068e into simple-icons:develop Mar 6, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the update/yammer branch March 9, 2020 09:41
@ericcornelissen ericcornelissen mentioned this pull request Mar 15, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
@ericcornelissen
Merge pull request #2788 from simple-icons/develop
eb60aaf 
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterShaggyNoble @ericcornelissen @runxel