Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google AdSense #2597

Merged
merged 3 commits into from Mar 11, 2020
Merged

Add Google AdSense #2597

merged 3 commits into from Mar 11, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Google AdSense

Issue: MDI#4614

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Had to take some artistic license with the cutout again.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 14, 2020
@phatbhoy67
Copy link
Contributor

phatbhoy67 commented Mar 7, 2020 •
edited

Hey @PeterShaggyNoble what did you base your interpretation on, I can't see that icon on the source referenced?

Did find a version here (https://upload.wikimedia.org/wikipedia/commons/c/cd/AdSense_Logo.svg) and based on that I think this is a good interpretation.

@phatbhoy67 phatbhoy67 added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 8, 2020
@PeterShaggyNoble
Copy link
Member Author

Ah, yes, the logo is only visible in the header when signed in to AdSense, otherwise it's just the wordmark. It is also displayed while the page loads if you click "Sign In" or "Get Started" but that isn't immediately obvious. Will update the source URL to file on Commons momentarily.

@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 9, 2020
phatbhoy67
phatbhoy67 approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good interpretation @PeterShaggyNoble but will await the view of another @simple-icons/maintainers before merging it in. 👍

@ericcornelissen
Copy link
Contributor

Hmm, seems GitHub has some problems rendering the SVG 😕 However, if I copy the SVG source into a file and load it in the browser everything works just fine. I don't have time to investigate this right now 😅 Any idea what might be the problem @PeterShaggyNoble? Do you experience the same? If not, I'm fine with merging this as is 👍

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Mar 10, 2020 •
edited

Definitely something up there, @ericcornelissen - even going direct to the file in my branch. The inability to retrieve the contributors is a new one on me, too.

Going to recreate it from source in a few minutes, see if that helps.

@PeterShaggyNoble
Copy link
Member Author

Nope, that solved nothing. No clue what's happening here 🤷‍♂ Any of the other @simple-icons/maintainers have any ideas?

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Mar 11, 2020 •
edited

I did some further testing (push the same file in a different folder with a different name, same folder different name, other folder same name, see here) and my conclusion: GitHub doesn't like the filename 🤣

I will merge this as is. Thanks for the work @PeterShaggyNoble 👍

@ericcornelissen ericcornelissen merged commit 5f59fbf into simple-icons:develop Mar 11, 2020
@PeterShaggyNoble
Copy link
Member Author

A-ha! It's not GitHub that doesn't like the filename, it's ad-blockers - I disabled mine and it loaded fine. Same problem with Google Ads.

@PeterShaggyNoble PeterShaggyNoble deleted the googleadsense branch March 11, 2020 13:05
@ericcornelissen
Copy link
Contributor

A-ha! It's not GitHub that doesn't like the filename, it's ad-blockers - I disabled mine and it loaded fine. Same problem with Google Ads.

Ow, that makes much more sense! 🤣

@ericcornelissen ericcornelissen mentioned this pull request Mar 15, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
@ericcornelissen
Merge pull request #2788 from simple-icons/develop
eb60aaf 
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatbhoy67 phatbhoy67 phatbhoy67 approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterShaggyNoble @phatbhoy67 @ericcornelissen