Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft Exchange #2621

Merged

Conversation

PeterShaggyNoble
Copy link
Member

Microsoft Exchange

Issue: Closes #2617

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The source URL isn't ideal as you need to dig around to find the icon in particular, but I couldn't find a single page source that featured both the colour and the new icon in monochrome. To get at the colour from the source URL is straightforward enough - it's the first page when you click through to the colours - but, to get at the icon, you need to go to iconography, scroll down to the end of the page and hit the "Fabric Core" tab ("Fabric React" still uses the old logo)

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 19, 2020
@ericcornelissen
Copy link
Contributor

I'm not against using this version of the logo, but why don't you use the version of the logo found on the product colors page? That is also the version of the logo you will find on this page and (but this shouldn't be the reason to switch) it simplifies the source URL.

@ericcornelissen ericcornelissen added the in discussion There is an ongoing discussion that should be finished before we can continue label Mar 8, 2020
@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Mar 9, 2020

That's their old logo, @ericcornelissen - there are a few on the product colours page that have not (yet) been updated. If you switch from "Fabric React" to "Fabric Core" on the second page you linked, you'll find the new logo there.

@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Mar 9, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's their old logo

Didn't realize that 😅 In that case this looks all good to me 👍

@ericcornelissen ericcornelissen merged commit 3574373 into simple-icons:develop Mar 9, 2020
@ericcornelissen
Copy link
Contributor

That finishes the updates and additions of Microsoft Office icons, thanks a bunch for all the work @PeterShaggyNoble 🎊

@PeterShaggyNoble PeterShaggyNoble deleted the microsoftexchange branch March 9, 2020 14:46
@PeterShaggyNoble
Copy link
Member Author

There are a few others but I don't think we need add them yet or even until they're requested.

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Mar 9, 2020

I guess that's what I meant 😆

ericcornelissen added a commit that referenced this pull request Mar 16, 2020
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft Exchange Server
2 participants