Update Redis #2677
Merged
Update Redis #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
added
the
update icon/data
ericcornelissen
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Looks good to me @PeterShaggyNoble 👍 Given that the colour is somewhat ambiguous and that inverting the logo is quite a big change, I will leave merging this to another @simple-icons/maintainers
Although, as I type that, I wonder should we go with the darker
#a32422red, rather than the lighter one in the PR?
I disagree, given that it is listed as "ADDITIONAL SECONDARY COLOR[S]". Though, based on the site I do see why you would suggest it 🙃
ericcornelissen
added a commit
that referenced
this pull request
Mar 16, 2020
# New icons - Bosch (#2661) - Ulule (#2714) - Shopware (#2698) - Castbox (#2715) - Plus Codes (#2717) - Vauxhall (#2647) - freedesktop.org (#2730) - ESLGaming (#2731) - BBC iPlayer (#2739) - Transport for London (#2742) - Gatling (#2741) - Farfetch (#2750) - Helly Hansen (#2747) - Roku (#2751) - Android Auto (#2542) - Ford (#2632) - Contactless Payment (#2584) - TeamSpeak (#2700) - Microsoft SharePoint (#2555) - PagSeguro (#2683) - Microsoft Visio (#2645) - Microsoft Exchange (#2621) - Puppet (#2694) - vBulletin (#2721) - PostCSS (#2759) - AdBlock (#2761) - HBO (#2760) - Apple TV (#2736) - Dash (#2728) - Clyp (#2725) - Vivaldi (#2724) - iBeacon (#2729) - Google AdSense (#2597) - Badgr (#2768) - Wikimedia Commons (#2685) - ProSieben (#2627) - Hyundai (#2641) - Honda (#2642) - Mazda (#2643) - Nissan (#2649) - Renault (#2651) - Windows XP (#2653) - ASKfm (#2608) - Lubuntu (#2644) - McDonald's (#2706) - Eclipse Mosquitto (#2718) - Bitwarden (#2719) - Alfa Romeo (#2744) - Adobe Fonts (#2776) - ŠKODA (#2657) - Bugatti (#2745) - libuv (#2720) - Volvo (#2755) - A-Frame (#2763) - Car Throttle (#2773) - OpenStack (#2772) - Adblock Plus (#2726) - WWE (#2612) - Phabricator (#2716) - Toyota (#2746) - Egnyte (#2723) - Warner Bros (#2704) - MAN (#2774) - App Store (#2611) - Chupa Chups (#2668) - Google Calendar (#2743) - Scania (#2775) - niconico (#2614) - Fiat (#2652) - WEMO (#2619) - Nintendo Network (#2780) - UpLabs (#2781) - WebMoney (#2782) # Updated icons - Google Maps (#2663) - Yammer (#2558) - Expo (#2594) - T-mobile (#2757) - Adobe Photoshop (#2733) - BMW (#2737) - Chase (#2722) - Riot (#2732) - Redis (#2677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #2667
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Went with the brand page as the source URL as the colour isn't featured on the homepage and it's easier to get back to the homepage to find the icon than it is to get to the brand page to find the colour. Although, as I type that, I wonder should we go with the darker
#a32422red, rather than the lighter one in the PR?