Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wikimedia Commons #2685

Merged
merged 2 commits into from Mar 11, 2020
Merged

Add Wikimedia Commons #2685

merged 2 commits into from Mar 11, 2020

Conversation

ericcornelissen
Copy link
Contributor

@ericcornelissen ericcornelissen commented Feb 26, 2020

Wikimedia Commons

Issue: Closes #2615

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Adds Wikimedia Commons logo, as discussed in #2615. I left the imperfection in the logo, as it is an official source, but I suppose that is up for debate.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Feb 26, 2020
@PeterShaggyNoble
Copy link
Member

Nice one, Eric. SVG & colour look good to me but, because of the imperfections and the manual fiddling to sort that curve out, we'll need one of the other @simple-icons/maintainers to review it too.

The only change I'd suggest is changing the source URL to https://commons.wikimedia.org/wiki/File:Commons-logo.svg as the homepage doesn't include a vector version of the logo anywhere, that I can see.

I took the liberty of editing a preview in for you, by the way; hope you don't mind.

@ericcornelissen
Copy link
Contributor Author

The only change I'd suggest is changing the source URL to https://commons.wikimedia.org/wiki/File:Commons-logo.svg as the homepage doesn't include a vector version of the logo anywhere, that I can see.

The logo in the top left is an SVG, at least for me... But I do think your source URL is better (especially given our freshly updated guidelines in #2567!). Will update it 👌

I took the liberty of editing a preview in for you, by the way; hope you don't mind.

Dang, forgot to do it myself 😅 Thank you!

@PeterShaggyNoble

This comment has been minimized.

@ericcornelissen

This comment has been minimized.

Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this one @ericcornelissen and @PeterShaggyNoble for reviewing issue 👍

@phatbhoy67 phatbhoy67 merged commit 8826334 into simple-icons:develop Mar 11, 2020
@ericcornelissen ericcornelissen deleted the icon/wikimedia branch March 11, 2020 18:40
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wikimedia Commons
3 participants