Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet icon #2694

Merged
merged 1 commit into from Mar 9, 2020
Merged

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Feb 27, 2020

Closes #2693

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The logo is manually converted in inkscape from the Puppet-Logo-Mark-Black.eps file in the media kit on the puppet homepage. The color code is the corporate amber.

@PeterShaggyNoble
Copy link
Member

Welcome to Simple Icons, @DavidS and thanks for the contribution.

The SVG looks good to me, other than the fact that it needs to be centred horizontally.

Can I ask, though, where you sourced the colour? I get #ffae1a from the website's stylesheet & SVG in the footer and #f9a512 from the amber logomark in their media kit (although CMYK -> HEX is often not exact).

@PeterShaggyNoble PeterShaggyNoble added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested new icon Issues or pull requests for adding a new icon labels Feb 27, 2020
@DavidS
Copy link
Contributor Author

DavidS commented Mar 9, 2020

Thanks for cross-checking that colour. I'll fix that and the centring.

@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 9, 2020
@DavidS
Copy link
Contributor Author

DavidS commented Mar 9, 2020

According to the media kit at https://puppet.com/company/press-room/, #ffae1a is the correct colour:

2020-03-09_15MS+0000_429x210

@PeterShaggyNoble
Copy link
Member

This looks good to me now, @DavidS - thanks for your work on it 👍

@PeterShaggyNoble PeterShaggyNoble merged commit e7d9b2b into simple-icons:develop Mar 9, 2020
@DavidS DavidS deleted the add-puppet-icon branch March 9, 2020 16:47
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puppet
2 participants