Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Warner Bros. #2704

Merged
merged 4 commits into from Mar 13, 2020
Merged

Conversation

PeterShaggyNoble
Copy link
Member

Warner Bros.

Issue: Closes #2690

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Colour from logo on Wikimedia

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 28, 2020
@phatbhoy67
Copy link
Contributor

Hey @PeterShaggyNoble thanks for your work on this one 👍

I am seeing differences in the path, with the PR version being slightly wider overall than the original resized, probably a precision issue, can you have a look and update please.

@PeterShaggyNoble
Copy link
Member Author

Turns out I completely forgot to optimise this one before submitting it 🤦‍♂ So couldn't figure out why you were seeing those differences. Ended up going back to the source and they'd updated the SVG on their site since I'd grabbed my copy! 🙄

PR updated to match.

Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @PeterShaggyNoble, height is showing as 24.001px.

Probably a precision issue, can you have a look and update please.

@PeterShaggyNoble
Copy link
Member Author

Thanks, @phatbhoy67 👍

Had to increase the precision to 4 to fix that little niggle 🙁

Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this one @PeterShaggyNoble 👍

@phatbhoy67 phatbhoy67 merged commit ca62faa into simple-icons:develop Mar 13, 2020
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
@PeterShaggyNoble PeterShaggyNoble deleted the warnerbros-dot branch March 16, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warner Bros.
2 participants