Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Egnyte #2723

Merged
merged 4 commits into from Mar 13, 2020
Merged

Egnyte #2723

merged 4 commits into from Mar 13, 2020

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Mar 3, 2020 •
edited

Egnyte

Issue: Templarian/MaterialDesign#2687

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I was hoping to get away with just using the icon, as they do in their favicon but then I spotted this line in the text of the source URL:

Please use without modification.

Alexa rank: 12447

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Mar 3, 2020
@phatbhoy67
Copy link
Contributor

Hey @PeterShaggyNoble is the source the egnyte-lightbg-vector.ai file available to download from the presskit page?

The .ai version is different to the logo.svg used in the header and footer of https://www.egnyte.com/.

The "Y" is configured differently.

The .ai file appears to be from 2013.

Is the .svg version fresher? 🤔

@phatbhoy67 phatbhoy67 added the in discussion There is an ongoing discussion that should be finished before we can continue label Mar 9, 2020
@PeterShaggyNoble
Copy link
Member Author

Well spotted, @phatbhoy67. I did indeed use the .ai file from the zip, without noticing the difference to the SVG. The SVG is newer - the lastModified date is the 16th of February 2019 - but I think, if we're to err on the side of caution, we should go with the version they provide in the press kit. Any thoughts from any of the other @simple-icons/maintainers?

@ericcornelissen
Copy link
Contributor

Well... that's a conundrum 😅 On their social media they also use a logo that looks like the SVG version. For the record. there are also raster versions of the logo in the press kit, from 23 March 2018, that look (at least to the eye) the same as the .ai version...

We may consider contacting them ("If you have requirements beyond what is provided, please contact us.") and ask about it? Otherwise I think I would be in favour of the SVG version as it is used more often, but it's difficult call given that the current version if from their press kit 😕

@PeterShaggyNoble PeterShaggyNoble added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Mar 12, 2020
@PeterShaggyNoble
Copy link
Member Author

Sent them an email, let's see what they say. Also chanced my arm and asked if we could just use the Y icon.

@PeterShaggyNoble
Copy link
Member Author

Egnyte have replied to say that, between the AI & the SVG, we should use the SVG so I've updated the PR based on that for now. They're going to get back to me on whether or not we're OK to use just the Y - path data is below so I can update from my phone later, if they say we can.

M22.544 8.74l-1.857-3.238c-.068-.113-.226-.159-.34-.091l-8.354 4.823L3.75 5.389a.256.256 0 0 0-.34.09l-1.9 3.238a.256.256 0 0 0 .09.34l8.332 4.89v9.804c0 .136.114.249.25.249h3.69c.136 0 .25-.113.25-.249v-9.849l8.331-4.823c.113-.068.159-.226.09-.339zm-16.03 6.566c-.068-.114-.227-.159-.363-.091l-5.57 3.306c-.113.068-.158.226-.09.362l.792 1.359c.068.113.227.158.363.09l5.57-3.306c.113-.068.158-.226.09-.362zM12.876 0l-1.834.023c-.068 0-.113.045-.113.135l.022 6.725c0 .068.046.113.136.113h1.834c.068 0 .113-.045.113-.136L13.012.136A.146.146 0 0 0 12.876 0zm10.596 18.158l-5.864-3.283c-.068-.022-.136-.022-.159.046l-.905 1.607c-.023.068-.023.136.045.159l5.864 3.283c.068.022.136.022.159-.045l.905-1.608c.046-.045.023-.136-.045-.159Z

@PeterShaggyNoble
Copy link
Member Author

They've confirmed that the Y icon is not an option so we're going with the SVG version of their logo.

@ericcornelissen ericcornelissen removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 13, 2020
ericcornelissen
ericcornelissen approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case this looks good to be merged 👍 Thanks for the work and for reaching out to them @PeterShaggyNoble 😄

@ericcornelissen ericcornelissen merged commit 0bd13f0 into simple-icons:develop Mar 13, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the egnyte branch March 13, 2020 12:26
@ericcornelissen ericcornelissen mentioned this pull request Mar 15, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
@ericcornelissen
Merge pull request #2788 from simple-icons/develop
eb60aaf 
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterShaggyNoble @phatbhoy67 @ericcornelissen