Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Toyota #2746

Merged
merged 1 commit into from Mar 12, 2020
Merged

Add Toyota #2746

merged 1 commit into from Mar 12, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Toyota

Issue: #2059 (Could've sworn one of us added this in the first round)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

At last a car manaufacturer with proper brand guidelines!

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Mar 6, 2020
@runxel runxel mentioned this pull request Mar 6, 2020
Closed
48 tasks
@PeterShaggyNoble
Copy link
Member Author

Forgot to include this alternative treatment, which is what I would have expected this to be but I didn't spot it in use or available anywhere in their brand guidelines.

Toyota

@ericcornelissen
Copy link
Contributor

I am very surprised the Visual Identity System shows the logo in a square 😕 I would totally expect your "alternative" treatment to be their logo... but given the guidelines I think the version currently in the PR is the way to go.

Any other opinions from the community or @simple-icons/maintainers?

phatbhoy67
phatbhoy67 approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR follows the brand guidelines, nice work @PeterShaggyNoble 👍

runxel
runxel reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, that's interesting. Also didn't expected it to be this.
Not really in favor of that, but what can we do? 🤷‍♂
My last resort is the argument they didn't put rectangle logos on their cars... 😅

@ericcornelissen ericcornelissen merged commit 3444a06 into simple-icons:develop Mar 12, 2020
@ericcornelissen
Copy link
Contributor

That seems to be some kind of consensus 😄 Thanks for the addition @PeterShaggyNoble

My last resort is the argument they didn't put rectangle logos on their cars...

As much as I love that argument, I'm afraid we're going with the rectangle version for now 🙃

@PeterShaggyNoble PeterShaggyNoble deleted the toyota branch March 13, 2020 11:59
@ericcornelissen ericcornelissen mentioned this pull request Mar 15, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
@ericcornelissen
Merge pull request #2788 from simple-icons/develop
eb60aaf 
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel left review comments

@phatbhoy67 phatbhoy67 phatbhoy67 approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeterShaggyNoble @ericcornelissen @runxel @phatbhoy67